issue_comments

Table actions

2 rows where issue = 717217552 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mathause · 2 ✖

issue 1

  • `combine_by_coords` fails giving StopIteration error · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
706766842 https://github.com/pydata/xarray/issues/4495#issuecomment-706766842 https://api.github.com/repos/pydata/xarray/issues/4495 MDEyOklzc3VlQ29tbWVudDcwNjc2Njg0Mg== mathause 10194086 2020-10-11T20:54:41Z 2020-10-11T20:54:41Z MEMBER

Following the data through combine_by_coords to _infer_concat_order_from_coords the following happens

https://github.com/pydata/xarray/blob/080caf4246fe2f4d6aa0c5dcb65a99b376fa669b/xarray/core/combine.py#L49

```python import pandas as pd

indexes = [da1.indexes["time"], da2.indexes["time"]]

first_items = pd.Index([index[0] for index in indexes]) series = first_items.to_series() series.rank(method="dense", ascending=ascending) which returnspython Series([], dtype: float64) thus it tries to iterate through an empty list. We probably need to setpython series.rank(method="dense", ascending=True, numeric_only=False) which raisespython <array_function internals> in lexsort(args, *kwargs)

cftime/_cftime.pyx in cftime._cftime.datetime.richcmp()

TypeError: cannot compare cftime.DatetimeGregorian(2000, 1, 1, 0, 0, 0, 0) and cftime.DatetimeProlepticGregorian(2001, 1, 1, 0, 0, 0, 0) (different calendars) ``` but I wonder what test failures this brings...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `combine_by_coords` fails giving StopIteration error 717217552
706749409 https://github.com/pydata/xarray/issues/4495#issuecomment-706749409 https://api.github.com/repos/pydata/xarray/issues/4495 MDEyOklzc3VlQ29tbWVudDcwNjc0OTQwOQ== mathause 10194086 2020-10-11T18:43:48Z 2020-10-11T18:43:48Z MEMBER

To reproduce:

```python import numpy as np import xarray as xr

time1 = xr.cftime_range("2000", "2000-12-31", calendar="standard") time2 = xr.cftime_range("2001", "2001-12-31", calendar="proleptic_gregorian")

da1 = xr.DataArray(np.random.randn(366), dims="time", coords=dict(time=time1)).to_dataset(name="name") da2 = xr.DataArray(np.random.randn(365), dims="time", coords=dict(time=time2)).to_dataset(name="name")

xr.combine_by_coords([da1, da2]) returnspython ... StopIteration: ```

Funny enough this does trigger the correct error: ```python time3 = xr.cftime_range("2000", "2000-12-31", calendar="proleptic_gregorian") da3 = xr.DataArray(np.random.randn(366), dims="time", coords=dict(time=time3)).to_dataset(name="name")

xr.combine_by_coords([da1, da3]) ```

python ... TypeError: cannot compare cftime.DatetimeProlepticGregorian(2000, 1, 1, 0, 0, 0, 0) and cftime.DatetimeGregorian(2000, 1, 1, 0, 0, 0, 0) (different calendars)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `combine_by_coords` fails giving StopIteration error 717217552

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);