issue_comments

Table actions

9 rows where issue = 713606589 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Add optional dependencies · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
709342096 https://github.com/pydata/xarray/pull/4480#issuecomment-709342096 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwOTM0MjA5Ng== mathause 10194086 2020-10-15T13:55:24Z 2020-10-15T13:55:24Z MEMBER

Thanks @ashwinvis and welcome to xarray!

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589
703322891 https://github.com/pydata/xarray/pull/4480#issuecomment-703322891 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMzMyMjg5MQ== mathause 10194086 2020-10-04T22:07:20Z 2020-10-04T22:13:16Z MEMBER

literalinclude is described here: https://www.sphinx-doc.org/en/3.x/markup/code.html#includes

Sounds good - it even seems possible to dynamically get the start and end:

Another way to control which part of the file is included is to use the start-after and end-before options (or only one of them). If start-after is given as a string option, only lines that follow the first line containing that string are included. If end-before is given as a string option, only lines that precede the first lines containing that string are included.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Add optional dependencies 713606589
703172986 https://github.com/pydata/xarray/pull/4480#issuecomment-703172986 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMzE3Mjk4Ng== ashwinvis 9155111 2020-10-03T22:36:39Z 2020-10-03T22:36:39Z CONTRIBUTOR

The only hiccup that I noticed was scitools-iris requires cartopy (which would install only if numpy is pre-installed), which in turn requires cf-units (which again would install if UDUNITS-2 library is present). I had gdal installed in my machine so I did not notice this. In short, it is best to avoid / mock scitools+ stuff if it can be avoided. I added it as a doc dependency because it is mandatory to have scitools+ packages - the way it is configured now. There is certainly room for future improvement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589
703170286 https://github.com/pydata/xarray/pull/4480#issuecomment-703170286 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMzE3MDI4Ng== mathause 10194086 2020-10-03T22:04:42Z 2020-10-03T22:04:42Z MEMBER

Thanks. The requirements for the docs are also listed here: https://github.com/pydata/xarray/blob/master/ci/requirements/doc.yml The docs also require cartopy which in turn depends on proj and gdal one of which is not installable with pip (can't remember which right now) - so the docs may require conda (or pip and quite some work).

Apart from this - LGTM but might good if someone else can have a look - @keewis? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589
703138718 https://github.com/pydata/xarray/pull/4480#issuecomment-703138718 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMzEzODcxOA== ashwinvis 9155111 2020-10-03T17:40:27Z 2020-10-03T17:40:27Z CONTRIBUTOR

Iris on PyPI is a dummy package. The package relevant for us is scitools-iris which can be difficult to install. That and some other packages should be installed to generate the docs. Ideally these should be mocked, maybe for another issue.

I tracked down all the dependencies required for docs. Could be useful for development.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589
702828541 https://github.com/pydata/xarray/pull/4480#issuecomment-702828541 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMjgyODU0MQ== mathause 10194086 2020-10-02T16:23:23Z 2020-10-02T16:23:23Z MEMBER

Yes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589
702808164 https://github.com/pydata/xarray/pull/4480#issuecomment-702808164 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMjgwODE2NA== ashwinvis 9155111 2020-10-02T15:44:00Z 2020-10-02T15:44:00Z CONTRIBUTOR

@mathause Something similar to https://docs.dask.org/en/latest/install.html#pip ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589
702794199 https://github.com/pydata/xarray/pull/4480#issuecomment-702794199 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMjc5NDE5OQ== mathause 10194086 2020-10-02T15:18:03Z 2020-10-02T15:18:03Z MEMBER

I assume this does not work with conda?

I thinks this should/ could be mentioned in https://github.com/pydata/xarray/blob/master/doc/installing.rst at the end of the Instructions section

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589
702743415 https://github.com/pydata/xarray/pull/4480#issuecomment-702743415 https://api.github.com/repos/pydata/xarray/issues/4480 MDEyOklzc3VlQ29tbWVudDcwMjc0MzQxNQ== dcherian 2448579 2020-10-02T13:46:29Z 2020-10-02T13:46:29Z MEMBER

Thanks @ashwinvis 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add optional dependencies 713606589

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);