issue_comments

Table actions

2 rows where issue = 707571360 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Change default for concat_characters to False in open_* functions · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
697959158 https://github.com/pydata/xarray/issues/4452#issuecomment-697959158 https://api.github.com/repos/pydata/xarray/issues/4452 MDEyOklzc3VlQ29tbWVudDY5Nzk1OTE1OA== dcherian 2448579 2020-09-23T20:36:57Z 2020-09-23T20:36:57Z MEMBER

we could make the default None in open_data* and set True/False appropriately for netCDF/Zarr backends?

technically we would need to warn for a couple of releases before changing the default in open_zarr but maybe no one cares too much?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change default for concat_characters to False in open_* functions 707571360
697928722 https://github.com/pydata/xarray/issues/4452#issuecomment-697928722 https://api.github.com/repos/pydata/xarray/issues/4452 MDEyOklzc3VlQ29tbWVudDY5NzkyODcyMg== shoyer 1217238 2020-09-23T19:34:48Z 2020-09-23T19:34:48Z MEMBER

I agree that there's is no good reason to use concat_characters for zarr, which supports normal fixed-width string datatypes.

For netCDF, we do need concat_character for the "NC_CHAR" dtype, which is used to store strings in lieu of a true fixed width string dtype. It's ugly, but otherwise we won't be able to round-trip string dtype arrays from xarray into netCDF3 files. This note from NetCDF.jl does a nice job of explaining.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change default for concat_characters to False in open_* functions 707571360

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);