issue_comments

Table actions

6 rows where issue = 702372014 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Fix for h5py deepcopy issues · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
695114125 https://github.com/pydata/xarray/pull/4426#issuecomment-695114125 https://api.github.com/repos/pydata/xarray/issues/4426 MDEyOklzc3VlQ29tbWVudDY5NTExNDEyNQ== dcherian 2448579 2020-09-18T22:31:13Z 2020-09-18T22:31:13Z MEMBER

Thanks @shoyer 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for h5py deepcopy issues 702372014
693111979 https://github.com/pydata/xarray/pull/4426#issuecomment-693111979 https://api.github.com/repos/pydata/xarray/issues/4426 MDEyOklzc3VlQ29tbWVudDY5MzExMTk3OQ== pep8speaks 24736507 2020-09-16T01:15:12Z 2020-09-18T20:59:40Z NONE

Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-09-18 20:59:40 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for h5py deepcopy issues 702372014
695048629 https://github.com/pydata/xarray/pull/4426#issuecomment-695048629 https://api.github.com/repos/pydata/xarray/issues/4426 MDEyOklzc3VlQ29tbWVudDY5NTA0ODYyOQ== shoyer 1217238 2020-09-18T19:34:14Z 2020-09-18T19:34:14Z MEMBER

Coincidentally I just pushed a regression test.

Assuming CI passes, this should be good to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for h5py deepcopy issues 702372014
695045824 https://github.com/pydata/xarray/pull/4426#issuecomment-695045824 https://api.github.com/repos/pydata/xarray/issues/4426 MDEyOklzc3VlQ29tbWVudDY5NTA0NTgyNA== dcherian 2448579 2020-09-18T19:27:24Z 2020-09-18T19:27:24Z MEMBER

Thanks for raising this @kmuehlbauer

Otherwise the new release might break existing code relying on behaviour before #4221.

@shoyer is this an OK temporary fix?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for h5py deepcopy issues 702372014
695041052 https://github.com/pydata/xarray/pull/4426#issuecomment-695041052 https://api.github.com/repos/pydata/xarray/issues/4426 MDEyOklzc3VlQ29tbWVudDY5NTA0MTA1Mg== kmuehlbauer 5821660 2020-09-18T19:15:08Z 2020-09-18T19:15:08Z MEMBER

Any chance to get this into 0.16.1? Otherwise the new release might break existing code relying on behaviour before #4221. Thanks for considering. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for h5py deepcopy issues 702372014
693185339 https://github.com/pydata/xarray/pull/4426#issuecomment-693185339 https://api.github.com/repos/pydata/xarray/issues/4426 MDEyOklzc3VlQ29tbWVudDY5MzE4NTMzOQ== kmuehlbauer 5821660 2020-09-16T05:45:01Z 2020-09-16T05:45:01Z MEMBER

@shoyer Thanks! I tested with the examples in #4425 and it fixes those issues. Would be great, if this could be merged before next release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for h5py deepcopy issues 702372014

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);