issue_comments

Hi @dcherian,

Thanks for the good idea! Changing the dataset that you want to plot is probably the easiest option.

Here is my implementation of that to go with my original code.

```python def change_ds_for_graph(dsA):

ds = dsA.copy()

for varname, da in ds.data_vars.items():
    for attr in da.attrs:
        if attr in ['units', 'long_name']:
            da.attrs[attr] = proper_units(tex_escape(da.attrs[attr]))

for coord in ds.coords:
    for attr in ds.coords[coord].attrs:
        if attr in ['units', 'long_name']:
            da.coords[coord].attrs[attr] = proper_units(tex_escape(da.coords[coord].attrs[attr]))

return ds

```

The plotting routines use da.attrs["long_name"] and da.attrs["units"].

For publication figures, I set these manually when reading data: da.attrs["long_name"] = "$J_q^t$" and da.attrs["units"] = "$W/m²$". Every plot after that is then nicely labeled.

Hi @fmaussion and @keewis,

Thank you for your comments, I agree that these changes are opinionated, and so probably inappropriate for inclusion in xarray itself.

I guess my motivation was that I could not see a way to loop through the text in a graph and apply some function to it. It might be easier to directly apply these functions to the text before labelling, rather than changing the labels after they are written, but I hope that this will be possible by using the accessor syntax as you suggest.

A more general version of this issue would be a method to pass a list of text-sanitizing-functions to xarray.plot.

Thank you for linking to salem and pint-xarray, I hadn't discovered those packages before, hopefully I will find some useful functionality there.

pint already supports printing units with latex, so you might be able to use pint and pint-xarray (and possibly cf-xarray for the definitions of degrees_north, etc.) in the future. See also xarray-contrib/pint-xarray#26.

Thanks a lot for this suggestion! I'll let the others chime in as well, but there are a few things to consider here: - xarray's plotting capability is not meant to be "publication ready" but "as close as possible to the data". I.e. units like degrees_north, etc. have to stay like this because it unambiguously shows where the data came from and how users can access it from the file, etc. - in general, making the plots nicer with opinionated defaults like yours would be a nice addition to the xarray ecosystem. It could live in a separate package, and use the accessor syntax to extend xarray. For example, my own little extension works this way and does opinionated stuff with the accessor: https://salem.readthedocs.io