issue_comments

Table actions

16 rows where issue = 694386155 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Fix doctests · 16 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
691319381 https://github.com/pydata/xarray/pull/4408#issuecomment-691319381 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTMxOTM4MQ== max-sixty 5635139 2020-09-11T21:27:06Z 2020-09-11T21:27:06Z MEMBER

For sure re CI!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
691262953 https://github.com/pydata/xarray/pull/4408#issuecomment-691262953 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTI2Mjk1Mw== keewis 14808389 2020-09-11T19:03:13Z 2020-09-11T19:03:13Z MEMBER

okay, then let's wait for #4409 which should fix the remaining three doctest failures.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
691262387 https://github.com/pydata/xarray/pull/4408#issuecomment-691262387 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTI2MjM4Nw== dcherian 2448579 2020-09-11T19:01:58Z 2020-09-11T19:01:58Z MEMBER

Sounds good to me. Thanks for working on this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
691252610 https://github.com/pydata/xarray/pull/4408#issuecomment-691252610 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTI1MjYxMA== keewis 14808389 2020-09-11T18:39:07Z 2020-09-11T18:39:07Z MEMBER

should we add a CI that checks that we don't regress?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
691216926 https://github.com/pydata/xarray/pull/4408#issuecomment-691216926 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTIxNjkyNg== max-sixty 5635139 2020-09-11T17:19:09Z 2020-09-11T17:19:09Z MEMBER

Thanks a lot @keewis ! This is a big step forward!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
691066913 https://github.com/pydata/xarray/pull/4408#issuecomment-691066913 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MTA2NjkxMw== keewis 14808389 2020-09-11T12:33:23Z 2020-09-11T12:33:44Z MEMBER

the failing hypothesis test looks unrelated, so I'm merging.

Edit: it seems RTD was fixed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690832039 https://github.com/pydata/xarray/pull/4408#issuecomment-690832039 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDgzMjAzOQ== max-sixty 5635139 2020-09-11T02:16:08Z 2020-09-11T02:16:08Z MEMBER

Great! To the extent the RTD build failure is not from this branch, shall we merge this now?

(i.e. feel free to merge!)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690812432 https://github.com/pydata/xarray/pull/4408#issuecomment-690812432 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDgxMjQzMg== max-sixty 5635139 2020-09-11T01:07:50Z 2020-09-11T01:07:50Z MEMBER

Great! To the extent the RTD build failure is not from this branch, shall we merge this now?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690618518 https://github.com/pydata/xarray/pull/4408#issuecomment-690618518 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDYxODUxOA== keewis 14808389 2020-09-10T18:51:33Z 2020-09-10T23:55:33Z MEMBER

wow. The RTD check fails due to: <frozen importlib._bootstrap>:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690791779 https://github.com/pydata/xarray/pull/4408#issuecomment-690791779 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDc5MTc3OQ== keewis 14808389 2020-09-10T23:55:00Z 2020-09-10T23:55:00Z MEMBER

@max-sixty, I removed the call to os.remove, instead every doctest gets its own temporary directory and by changing to that directory first, any file will be written into it. This seems a bit wasteful because not every doctest needs a temporary directory (actually, the vast majority doesn't), but I couldn't find an option to enable that only for certain tests. The doctests still complete within a few seconds, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690735540 https://github.com/pydata/xarray/pull/4408#issuecomment-690735540 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDczNTU0MA== keewis 14808389 2020-09-10T21:14:57Z 2020-09-10T21:14:57Z MEMBER

the main build is also failing so I guess this is unrelated. There is a numpy release PR in the feedstock, maybe that will fix it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690715146 https://github.com/pydata/xarray/pull/4408#issuecomment-690715146 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDcxNTE0Ng== keewis 14808389 2020-09-10T20:41:24Z 2020-09-10T20:41:24Z MEMBER

I raised an eyebrow about the os.remove but it's limited to a finite set of paths.

yeah, well, I didn't want to leave files lying around. Not sure if there's a better way to do that. Maybe if there's a way to have pytest create a temporary directory we could use that to construct the paths?

we could add an ignore in the doctest prelude

I doubt that would fix it (maybe I'm missing something), these are triggered by ipython directives (combining.rst, groupby.rst). I'll try rerunning the RTD check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690710321 https://github.com/pydata/xarray/pull/4408#issuecomment-690710321 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDcxMDMyMQ== max-sixty 5635139 2020-09-10T20:31:40Z 2020-09-10T20:31:40Z MEMBER

Looks great! I raised an eyebrow about the os.remove but it's limited to a finite set of paths.

Re the warning, we could add an ignore in the doctest prelude?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
690617025 https://github.com/pydata/xarray/pull/4408#issuecomment-690617025 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY5MDYxNzAyNQ== keewis 14808389 2020-09-10T18:49:09Z 2020-09-10T18:49:23Z MEMBER

I tried to fix the remaining doctests that were unrelated to #4409, so those need a review first (especially the StackedBytesArray and indexing doctests).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
689754212 https://github.com/pydata/xarray/pull/4408#issuecomment-689754212 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY4OTc1NDIxMg== dcherian 2448579 2020-09-09T18:59:41Z 2020-09-09T18:59:41Z MEMBER

shall we merge and deal with the effects of #4409 later?

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155
687930457 https://github.com/pydata/xarray/pull/4408#issuecomment-687930457 https://api.github.com/repos/pydata/xarray/issues/4408 MDEyOklzc3VlQ29tbWVudDY4NzkzMDQ1Nw== max-sixty 5635139 2020-09-06T23:17:37Z 2020-09-06T23:17:37Z MEMBER

that was a entirely manual process. However, it should be possible to write a script using doctest.DoctestParser, doctest.DoctestFinder and doctest.DoctestRunner (and I would be surprised if there's nothing like that already).

Well, thanks for doing all that!

On the tool, I agree that would be great. Here's something I did in a day that aimed to do it for any value rather than doctests. Would be easier and less complicated for doctests: https://github.com/max-sixty/pytest-accept

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix doctests 694386155

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);