issue_comments

Table actions

10 rows where issue = 690546795 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • [WIP] Support nano second time encoding. · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1484222279 https://github.com/pydata/xarray/pull/4400#issuecomment-1484222279 https://api.github.com/repos/pydata/xarray/issues/4400 IC_kwDOAMm_X85Yd29H hmaarrfk 90008 2023-03-26T20:59:00Z 2023-03-26T20:59:00Z CONTRIBUTOR

nice!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
1484209092 https://github.com/pydata/xarray/pull/4400#issuecomment-1484209092 https://api.github.com/repos/pydata/xarray/issues/4400 IC_kwDOAMm_X85YdzvE dcherian 2448579 2023-03-26T20:08:50Z 2023-03-26T20:08:50Z MEMBER

The merge conflict suggests this was fixed on main by #4684

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
735777126 https://github.com/pydata/xarray/pull/4400#issuecomment-735777126 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNTc3NzEyNg== aldanor 2418513 2020-11-30T13:12:47Z 2020-11-30T13:12:47Z NONE

Yea, well, in this case it's not about Python... M8[ns] datatype is simply an int64 underneath, why not just store it as that, no bells and whistles required, no corruption possible, no funky conversions?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
735759416 https://github.com/pydata/xarray/pull/4400#issuecomment-735759416 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNTc1OTQxNg== hmaarrfk 90008 2020-11-30T12:33:33Z 2020-11-30T12:33:33Z CONTRIBUTOR

I think you should be able to define your own custom encoder if you want it to be a datetime.

But inevitably, you will have to define your own save and load functions.

Python, by definition of being such a loose language, allows you to do things that the original developers never really imagined.

this can sometimes lead to silent corruption.like the one you've experienced.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
735431187 https://github.com/pydata/xarray/pull/4400#issuecomment-735431187 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNTQzMTE4Nw== aldanor 2418513 2020-11-29T17:52:37Z 2020-11-29T17:52:37Z NONE

I'm working on an application where nanosecond-resolution is critical and took me days to find why my timestamps are all scrambled or off-by-1 after I write them with xarray and them read them back... would probably much rather prefer if it threw an exception instead of corrupting your data silently.

Non-standard netcdf or not, if it was possible to just store them as plain int64s and read them back as is, that would help a ton...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
735430231 https://github.com/pydata/xarray/pull/4400#issuecomment-735430231 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNTQzMDIzMQ== aldanor 2418513 2020-11-29T17:45:14Z 2020-11-29T17:45:14Z NONE

I think netcdf lists "nanoseconds" as a valid unit though?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
735428578 https://github.com/pydata/xarray/pull/4400#issuecomment-735428578 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNTQyODU3OA== hmaarrfk 90008 2020-11-29T17:32:37Z 2020-11-29T17:32:37Z CONTRIBUTOR

yeah, i'm not too sure. I think the idea is that this breaks compatibility with netcdf times, so the resulting file is thus not standard.

For my application, us timing is enough.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
734963454 https://github.com/pydata/xarray/pull/4400#issuecomment-734963454 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNDk2MzQ1NA== aldanor 2418513 2020-11-27T19:38:47Z 2020-11-27T19:38:47Z NONE

But the test already passes (i.e. you can at least do a .encoding={.... 'nanoseconds'} and avoid float conversion?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
734962866 https://github.com/pydata/xarray/pull/4400#issuecomment-734962866 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNDk2Mjg2Ng== aldanor 2418513 2020-11-27T19:36:02Z 2020-11-27T19:36:02Z NONE

Oh, that requires cftime._cftime support first? :/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795
734962563 https://github.com/pydata/xarray/pull/4400#issuecomment-734962563 https://api.github.com/repos/pydata/xarray/issues/4400 MDEyOklzc3VlQ29tbWVudDczNDk2MjU2Mw== aldanor 2418513 2020-11-27T19:34:48Z 2020-11-27T19:34:48Z NONE

Is there anything preventing to merge this? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] Support nano second time encoding. 690546795

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);