issue_comments

Table actions

4 rows where issue = 689502005 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • WIP: Ensure that zarr.ZipStores are closed · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1411104404 https://github.com/pydata/xarray/pull/4395#issuecomment-1411104404 https://api.github.com/repos/pydata/xarray/issues/4395 IC_kwDOAMm_X85UG76U hmaarrfk 90008 2023-01-31T21:39:15Z 2023-01-31T21:39:15Z CONTRIBUTOR

Ultimately, I'm not sure how you want to manage resources. This zarr store could be considered a resource and thus, may have an owner. Or maybe zarr should close itself upon garbage cleanup.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Ensure that zarr.ZipStores are closed 689502005
1411102778 https://github.com/pydata/xarray/pull/4395#issuecomment-1411102778 https://api.github.com/repos/pydata/xarray/issues/4395 IC_kwDOAMm_X85UG7g6 hmaarrfk 90008 2023-01-31T21:38:23Z 2023-01-31T21:38:23Z CONTRIBUTOR

I'm not sure. I decided not to use zarr (not now) so i lost interest sorry.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Ensure that zarr.ZipStores are closed 689502005
1410626513 https://github.com/pydata/xarray/pull/4395#issuecomment-1410626513 https://api.github.com/repos/pydata/xarray/issues/4395 IC_kwDOAMm_X85UFHPR jhamman 2443309 2023-01-31T15:48:17Z 2023-01-31T15:48:17Z MEMBER

@hmaarrfk - wondering what your current thoughts on this issue are? Perhaps this can be handled better upstream in zarr-python? Should we close this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Ensure that zarr.ZipStores are closed 689502005
684064522 https://github.com/pydata/xarray/pull/4395#issuecomment-684064522 https://api.github.com/repos/pydata/xarray/issues/4395 MDEyOklzc3VlQ29tbWVudDY4NDA2NDUyMg== hmaarrfk 90008 2020-08-31T21:59:28Z 2020-08-31T21:59:28Z CONTRIBUTOR

I'm not too sure about this anymore.

with the way the test is written now, it is unclear to me if the store should be closed afterward.

I'm also unsure of how to deal with the case where the user passed it a ZipStore instead of a string. Will have to keep thinking.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Ensure that zarr.ZipStores are closed 689502005

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);