issue_comments

Table actions

2 rows where issue = 684078209 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Silencing numpy warnings · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
686061744 https://github.com/pydata/xarray/pull/4369#issuecomment-686061744 https://api.github.com/repos/pydata/xarray/issues/4369 MDEyOklzc3VlQ29tbWVudDY4NjA2MTc0NA== max-sixty 5635139 2020-09-02T22:28:22Z 2020-09-02T22:28:22Z MEMBER

LGTM, but the linter-enforced else clause seems a bit strange to me

Yeah, I think it makes sense the context of the function alone — it doesn't know that the values are limited to the two parameterizations. Though this fix trades one error for another, in the end.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silencing numpy warnings 684078209
683254964 https://github.com/pydata/xarray/pull/4369#issuecomment-683254964 https://api.github.com/repos/pydata/xarray/issues/4369 MDEyOklzc3VlQ29tbWVudDY4MzI1NDk2NA== mathause 10194086 2020-08-29T08:09:19Z 2020-08-29T08:09:19Z MEMBER

I think this thread suggests to use warning: https://github.com/numpy/numpy/issues/10709

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silencing numpy warnings 684078209

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);