issue_comments

Table actions

9 rows where issue = 681528611 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Allow cov & corr to handle missing values · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
679238731 https://github.com/pydata/xarray/pull/4351#issuecomment-679238731 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3OTIzODczMQ== dcherian 2448579 2020-08-24T16:40:05Z 2020-08-24T16:40:05Z MEMBER

Thanks @max-sixty 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
679184273 https://github.com/pydata/xarray/pull/4351#issuecomment-679184273 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3OTE4NDI3Mw== pep8speaks 24736507 2020-08-24T15:07:12Z 2020-08-24T15:41:53Z NONE

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-08-24 15:41:53 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
678677055 https://github.com/pydata/xarray/pull/4351#issuecomment-678677055 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3ODY3NzA1NQ== max-sixty 5635139 2020-08-22T18:44:22Z 2020-08-22T18:44:22Z MEMBER

Lmk any thoughts. I had added some more tests for nd reductions. Otherwise will merge later!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
677797269 https://github.com/pydata/xarray/pull/4351#issuecomment-677797269 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3Nzc5NzI2OQ== max-sixty 5635139 2020-08-20T17:25:46Z 2020-08-20T17:25:46Z MEMBER

This is ready to go on green

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
676514966 https://github.com/pydata/xarray/pull/4351#issuecomment-676514966 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3NjUxNDk2Ng== max-sixty 5635139 2020-08-19T16:01:40Z 2020-08-19T16:01:40Z MEMBER

My bad ;)

Ha, no stress @AndrewWilliams3142 ! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
676494680 https://github.com/pydata/xarray/pull/4351#issuecomment-676494680 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3NjQ5NDY4MA== AndrewILWilliams 56925856 2020-08-19T15:25:16Z 2020-08-19T15:25:16Z CONTRIBUTOR

The test is not in a function. I think the link to the test looks like it is indented but it's not...

My bad ;) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
676413561 https://github.com/pydata/xarray/pull/4351#issuecomment-676413561 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3NjQxMzU2MQ== mathause 10194086 2020-08-19T14:05:11Z 2020-08-19T14:05:11Z MEMBER

The test is not in a function. I think the link to the test looks like it is indented but it's not... 

{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 2,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
676398501 https://github.com/pydata/xarray/pull/4351#issuecomment-676398501 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3NjM5ODUwMQ== max-sixty 5635139 2020-08-19T13:55:16Z 2020-08-19T13:55:16Z MEMBER

BTW: There is a bare test with xr.corr that made its way into test_computation.py:

https://github.com/pydata/xarray/blob/a7fb5a9fa1a2b829181ea9e4986b959f315350dd/xarray/tests/test_computation.py#L898-L899

could you also fix this?

Sure — though what's wrong with it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611
675924541 https://github.com/pydata/xarray/pull/4351#issuecomment-675924541 https://api.github.com/repos/pydata/xarray/issues/4351 MDEyOklzc3VlQ29tbWVudDY3NTkyNDU0MQ== mathause 10194086 2020-08-19T08:14:01Z 2020-08-19T08:14:01Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow cov & corr to handle missing values 681528611

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);