issue_comments

Table actions

4 rows where issue = 679575175 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • max-sixty · 4 ✖

issue 1

  • Improve Dataset documentation · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
674589019 https://github.com/pydata/xarray/issues/4345#issuecomment-674589019 https://api.github.com/repos/pydata/xarray/issues/4345 MDEyOklzc3VlQ29tbWVudDY3NDU4OTAxOQ== max-sixty 5635139 2020-08-16T23:02:14Z 2020-08-18T19:57:11Z MEMBER

Maybe we keep it focused on one issue, but another oddity — JupyterLab seems to list the signature as xr.Dataset(*args, **kwds), but the signature is explicit: https://github.com/pydata/xarray/blob/v0.16.0/xarray/core/dataset.py#L468-L475

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset documentation 679575175
674588981 https://github.com/pydata/xarray/issues/4345#issuecomment-674588981 https://api.github.com/repos/pydata/xarray/issues/4345 MDEyOklzc3VlQ29tbWVudDY3NDU4ODk4MQ== max-sixty 5635139 2020-08-16T23:01:55Z 2020-08-16T23:01:55Z MEMBER

Thanks @keewis , good spot.

That looks right @Illviljan , so unless there's other information, it looks like we should move it to the class.

Is there any reason to keep it on the __init__?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset documentation 679575175
674557633 https://github.com/pydata/xarray/issues/4345#issuecomment-674557633 https://api.github.com/repos/pydata/xarray/issues/4345 MDEyOklzc3VlQ29tbWVudDY3NDU1NzYzMw== max-sixty 5635139 2020-08-16T18:01:48Z 2020-08-16T18:01:48Z MEMBER

Any idea whether this is a Spyder issue only or more general?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset documentation 679575175
674453249 https://github.com/pydata/xarray/issues/4345#issuecomment-674453249 https://api.github.com/repos/pydata/xarray/issues/4345 MDEyOklzc3VlQ29tbWVudDY3NDQ1MzI0OQ== max-sixty 5635139 2020-08-15T22:28:18Z 2020-08-15T22:28:18Z MEMBER

Thanks for the feedback; I agree there's more to initializing a Dataset than a DataFrame, and we should make the docs as accessible as possible.

In this specific case, is this a Spyder issue only or more general? IIUC using the __init__ or the class are both standard for the class docstring

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve Dataset documentation 679575175

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);