issue_comments

Table actions

11 rows where issue = 676696822 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Support explicitly setting a dimension order with to_dataframe() · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
676675240 https://github.com/pydata/xarray/pull/4333#issuecomment-676675240 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3NjY3NTI0MA== hammer 15233 2020-08-19T20:37:37Z 2020-08-19T20:37:37Z NONE

Just noting for GitHub metadata purposes that this PR addresses the Dataset.to_dataframe annotation request in https://github.com/pydata/xarray/issues/4238

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
674361521 https://github.com/pydata/xarray/pull/4333#issuecomment-674361521 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3NDM2MTUyMQ== Thomas-Z 1492047 2020-08-15T07:20:53Z 2020-08-15T07:20:53Z CONTRIBUTOR

My pleasure. I've been a user for a few years now, I'll gladly give something back whenever I can.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
674271421 https://github.com/pydata/xarray/pull/4333#issuecomment-674271421 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3NDI3MTQyMQ== max-sixty 5635139 2020-08-14T21:03:54Z 2020-08-14T21:03:54Z MEMBER

Thanks @Thomas-Z ! Great to have you as a contributor

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
674206025 https://github.com/pydata/xarray/pull/4333#issuecomment-674206025 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3NDIwNjAyNQ== dcherian 2448579 2020-08-14T18:28:23Z 2020-08-14T18:28:23Z MEMBER

Thanks @Thomas-Z . I see this is your first PR here. Welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
672088818 https://github.com/pydata/xarray/pull/4333#issuecomment-672088818 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3MjA4ODgxOA== shoyer 1217238 2020-08-11T16:53:59Z 2020-08-11T16:53:59Z MEMBER

Do we want DataArray.to_dataframe to be consistent with Dataset.to_dataframe regarding the default dimension ordering (i.e. alphabetically) or do we want to keep the current behavior (DataArray.dims order)?

DataArray.to_dataframe() should keep the current behavior based on the dimension order.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
672084936 https://github.com/pydata/xarray/pull/4333#issuecomment-672084936 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3MjA4NDkzNg== Thomas-Z 1492047 2020-08-11T16:49:19Z 2020-08-11T16:49:19Z CONTRIBUTOR

Do we want DataArray.to_dataframe to be consistent with Dataset.to_dataframe regarding the default dimension ordering (i.e. alphabetically) or do we want to keep the current behavior (DataArray.dims order)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
672081839 https://github.com/pydata/xarray/pull/4333#issuecomment-672081839 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3MjA4MTgzOQ== shoyer 1217238 2020-08-11T16:44:23Z 2020-08-11T16:44:23Z MEMBER

I like dim_order a little bit better than dims because it's clear that you need supply all the dimensions, not just a subset (which is usually the case for dims)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
672055923 https://github.com/pydata/xarray/pull/4333#issuecomment-672055923 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3MjA1NTkyMw== dcherian 2448579 2020-08-11T16:10:24Z 2020-08-11T16:10:24Z MEMBER

OK consistency with to_dask_dataframe is a good idea. Maybe stick with dim_order for now and we can change both later if someone really wants it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
672030936 https://github.com/pydata/xarray/pull/4333#issuecomment-672030936 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3MjAzMDkzNg== Thomas-Z 1492047 2020-08-11T15:51:02Z 2020-08-11T15:54:40Z CONTRIBUTOR

Hello,

I actually followed @shoyer suggestion to use to_dask_dataframe parameter name.

And I just realized I only did half the work. I'll add this parameter to DataArray.to_dataframe if you validate this name.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
672026071 https://github.com/pydata/xarray/pull/4333#issuecomment-672026071 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3MjAyNjA3MQ== dcherian 2448579 2020-08-11T15:42:53Z 2020-08-11T15:42:53Z MEMBER

How about dims: Iterable[Hashable]?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822
671956314 https://github.com/pydata/xarray/pull/4333#issuecomment-671956314 https://api.github.com/repos/pydata/xarray/issues/4333 MDEyOklzc3VlQ29tbWVudDY3MTk1NjMxNA== max-sixty 5635139 2020-08-11T13:45:33Z 2020-08-11T13:45:33Z MEMBER

Great, thanks @Thomas-Z , LGTM

Does anyone have thoughts on the kwarg name? dim_order seems reasonable, though IIRC we don't use it elsewhere

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support explicitly setting a dimension order with to_dataframe() 676696822

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);