issue_comments

Table actions

7 rows where issue = 671108068 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Increase support window of all dependencies · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
673751996 https://github.com/pydata/xarray/pull/4296#issuecomment-673751996 https://api.github.com/repos/pydata/xarray/issues/4296 MDEyOklzc3VlQ29tbWVudDY3Mzc1MTk5Ng== shoyer 1217238 2020-08-13T23:04:49Z 2020-08-13T23:04:49Z MEMBER

support set a feature flag, so now RTD appends to our environment file instead of executing multiple install commands. That means version pinning of sphinx works and the docs CI should hopefully pass.

Awesome, thanks for digging in here! Multiple install commands in RTD has been persistently very painful / error-prone.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase support window of all dependencies 671108068
673750608 https://github.com/pydata/xarray/pull/4296#issuecomment-673750608 https://api.github.com/repos/pydata/xarray/issues/4296 MDEyOklzc3VlQ29tbWVudDY3Mzc1MDYwOA== keewis 14808389 2020-08-13T23:00:03Z 2020-08-13T23:00:03Z MEMBER

support set a feature flag, so now RTD appends to our environment file instead of executing multiple install commands. That means version pinning of sphinx works and the docs CI should hopefully pass.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Increase support window of all dependencies 671108068
672847488 https://github.com/pydata/xarray/pull/4296#issuecomment-672847488 https://api.github.com/repos/pydata/xarray/issues/4296 MDEyOklzc3VlQ29tbWVudDY3Mjg0NzQ4OA== keewis 14808389 2020-08-12T12:42:41Z 2020-08-12T12:42:41Z MEMBER

the failing docs CI is indeed unrelated and will be fixed by #4286

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase support window of all dependencies 671108068
672816445 https://github.com/pydata/xarray/pull/4296#issuecomment-672816445 https://api.github.com/repos/pydata/xarray/issues/4296 MDEyOklzc3VlQ29tbWVudDY3MjgxNjQ0NQ== crusaderky 6213168 2020-08-12T11:30:30Z 2020-08-12T11:30:30Z MEMBER

@max-sixty definitely unrelated

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase support window of all dependencies 671108068
672555246 https://github.com/pydata/xarray/pull/4296#issuecomment-672555246 https://api.github.com/repos/pydata/xarray/issues/4296 MDEyOklzc3VlQ29tbWVudDY3MjU1NTI0Ng== max-sixty 5635139 2020-08-12T03:45:23Z 2020-08-12T03:45:23Z MEMBER

I'm guessing the docs failure is unrelated — I can't see why this would be affected and there doesn't seem to be any error in the logs. Does that sound right?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase support window of all dependencies 671108068
672377186 https://github.com/pydata/xarray/pull/4296#issuecomment-672377186 https://api.github.com/repos/pydata/xarray/issues/4296 MDEyOklzc3VlQ29tbWVudDY3MjM3NzE4Ng== crusaderky 6213168 2020-08-12T00:04:35Z 2020-08-12T00:04:35Z MEMBER

To confirm, this is still "the oldest version released within the time period", rather than "the version that existed at the start of the time period"

Yes, this hasn't changed.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase support window of all dependencies 671108068
671954538 https://github.com/pydata/xarray/pull/4296#issuecomment-671954538 https://api.github.com/repos/pydata/xarray/issues/4296 MDEyOklzc3VlQ29tbWVudDY3MTk1NDUzOA== max-sixty 5635139 2020-08-11T13:42:24Z 2020-08-11T13:42:24Z MEMBER

Thanks @crusaderky , LGTM

To confirm, this is still "the oldest version released within the time period", rather than "the version that existed at the start of the time period"

(which as discussed in other threads is a bit odd, but that's what numpy does so...)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase support window of all dependencies 671108068

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);