issue_comments

Table actions

3 rows where issue = 668905666 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • resample function gives 0s instead of NaNs · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
669309611 https://github.com/pydata/xarray/issues/4291#issuecomment-669309611 https://api.github.com/repos/pydata/xarray/issues/4291 MDEyOklzc3VlQ29tbWVudDY2OTMwOTYxMQ== max-sixty 5635139 2020-08-05T16:55:58Z 2020-08-05T16:55:58Z MEMBER

Yes, IIRC there have been extensive discussion about this over at pandas.

To the the extent there's anything that doesn't pandas' convention, please let us know, that wouldn't be intentional.

I'll close this for now but please reopen with any other questions. Thanks for raising @xzenggit .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   resample function gives 0s instead of NaNs 668905666
666674009 https://github.com/pydata/xarray/issues/4291#issuecomment-666674009 https://api.github.com/repos/pydata/xarray/issues/4291 MDEyOklzc3VlQ29tbWVudDY2NjY3NDAwOQ== xzenggit 8161792 2020-07-30T20:28:28Z 2020-07-30T20:28:28Z NONE

Thanks. It'll make more sense if the default value of min_count is 1 instead of 0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   resample function gives 0s instead of NaNs 668905666
666616365 https://github.com/pydata/xarray/issues/4291#issuecomment-666616365 https://api.github.com/repos/pydata/xarray/issues/4291 MDEyOklzc3VlQ29tbWVudDY2NjYxNjM2NQ== max-sixty 5635139 2020-07-30T19:14:26Z 2020-07-30T19:14:44Z MEMBER

I agree this isn't that clear. I think min_count will solve this.

In [20]: da.resample(time='1d').sum(min_count=1) Out[20]: <xarray.DataArray (time: 153)> array([ nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan,

IIRC this mirrors pandas, would be keen to know if that's not the case

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   resample function gives 0s instead of NaNs 668905666

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);