issue_comments

Table actions

2 rows where issue = 668717850 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 2 ✖

issue 1

  • bool(Dataset(False)) is True · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
669224849 https://github.com/pydata/xarray/issues/4290#issuecomment-669224849 https://api.github.com/repos/pydata/xarray/issues/4290 MDEyOklzc3VlQ29tbWVudDY2OTIyNDg0OQ== max-sixty 5635139 2020-08-05T14:25:55Z 2020-08-05T14:25:55Z MEMBER

Thanks for raising and engaging @aaronspring !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bool(Dataset(False)) is True 668717850
666610284 https://github.com/pydata/xarray/issues/4290#issuecomment-666610284 https://api.github.com/repos/pydata/xarray/issues/4290 MDEyOklzc3VlQ29tbWVudDY2NjYxMDI4NA== max-sixty 5635139 2020-07-30T19:10:27Z 2020-07-30T19:10:27Z MEMBER

We mirror numpy for DataArray and, per @keewis , Mapping for Dataset. I think we should have a fairly high bar for deviating from those.

For those who think bool(xr.Dataset(dict(x=False))) should evaluate to False, what do you think dict(x=False) should evaluate to?

IIUC, this is somewhat of an edge case — it's only possible to coerce DataArray to bool when there's exactly one element. (Not that we shouldn't resolve)

This question seems to me to be conceptually similar to the question I described in #3315: "Should we treat a named DataArray and a single-variable Dataset as if they are the same?"

👍 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bool(Dataset(False)) is True 668717850

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);