issue_comments

Table actions

6 rows where issue = 655382009 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • fujiisoup · 6 ✖

issue 1

  • what is the best way to reset an unintentional direct push to the master · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
657273886 https://github.com/pydata/xarray/issues/4218#issuecomment-657273886 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzI3Mzg4Ng== fujiisoup 6815844 2020-07-12T20:55:53Z 2020-07-12T20:55:53Z MEMBER

I think the preferred option for dealing with accidentally pushed changes is to push a "revert" commit generated from git revert

OK, understood.

but as long as we keep the master branch protected, it's always possible always possible to move forward by reverting changes -- there is no way to lose work.

Then, probably the most dangarous part was when I unprotected the master branch. I was afraid of messing up the commit history, but it is much better than losing entire commit history...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   what is the best way to reset an unintentional direct push to the master 655382009
657215217 https://github.com/pydata/xarray/issues/4218#issuecomment-657215217 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxNTIxNw== fujiisoup 6815844 2020-07-12T12:26:41Z 2020-07-12T12:26:41Z MEMBER

OK, thanks.

So I think either a pre-push hook or git config branch.master.pushRemote no_push (but then you also can't push to your own master anymore) are the best way forward

Agreed. I'll use your pre-push hook. Thanks @keewis .

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   what is the best way to reset an unintentional direct push to the master 655382009
657212192 https://github.com/pydata/xarray/issues/4218#issuecomment-657212192 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxMjE5Mg== fujiisoup 6815844 2020-07-12T11:59:11Z 2020-07-12T11:59:11Z MEMBER

BTW, is it possible to disallow direct push to master on github? Maybe we only need to merge PRs and but not push.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   what is the best way to reset an unintentional direct push to the master 655382009
657211959 https://github.com/pydata/xarray/issues/4218#issuecomment-657211959 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxMTk1OQ== fujiisoup 6815844 2020-07-12T11:56:34Z 2020-07-12T11:56:34Z MEMBER

OK. Done. Thanks. I'll use your script. Thanks.

And sorry again for my mistake.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   what is the best way to reset an unintentional direct push to the master 655382009
657211712 https://github.com/pydata/xarray/issues/4218#issuecomment-657211712 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxMTcxMg== fujiisoup 6815844 2020-07-12T11:54:40Z 2020-07-12T11:54:40Z MEMBER

Maybe I can unprotect the master, but I'm hesitating this action...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   what is the best way to reset an unintentional direct push to the master 655382009
657211365 https://github.com/pydata/xarray/issues/4218#issuecomment-657211365 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxMTM2NQ== fujiisoup 6815844 2020-07-12T11:51:31Z 2020-07-12T11:51:31Z MEMBER

Thanks. but it looks the master is protected and I cannot force push. Total 0 (delta 0), reused 0 (delta 0) remote: error: GH006: Protected branch update failed for refs/heads/master. remote: error: Cannot force-push to this protected branch To https://github.com/pydata/xarray.git ! [remote rejected] master -> master (protected branch hook declined) error: failed to push some refs to 'https://github.com/pydata/xarray.git'

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   what is the best way to reset an unintentional direct push to the master 655382009

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);