home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

4 rows where issue = 655382009 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 4 ✖

issue 1

  • what is the best way to reset an unintentional direct push to the master · 4 ✖

author_association 1

  • MEMBER 4
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
657275143 https://github.com/pydata/xarray/issues/4218#issuecomment-657275143 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzI3NTE0Mw== keewis 14808389 2020-07-12T21:06:38Z 2020-07-12T21:07:33Z MEMBER

this was actually not that dangerous since everyone who synced the git history (i.e. at least @max-sixty) before that accident had a full "backup" of the commit history.

Would it make sense to add a section for "people with commit access" to contributing.rst? I imagine this could be useful as a reference and for new maintainers...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  what is the best way to reset an unintentional direct push to the master 655382009
657210253 https://github.com/pydata/xarray/issues/4218#issuecomment-657210253 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxMDI1Mw== keewis 14808389 2020-07-12T11:39:58Z 2020-07-12T13:23:34Z MEMBER

you could try to undo that by: getting the hash of the latest commit (7bf9df9d75c40bcbf2dd28c47204529a76561a3f right now), then calling sh git reset <hash> git push -f

Since I've been afraid of that mistake as well, I added a git hook that makes git refuse to push to master and stable on the main repository (use --no-verify to override it): ```bash $ cat .git/hooks/pre-push

!/usr/bin/env bash

protected_remotes="origin" protected_branches="master stable"

isin() { local list="$1" local substring="$2"

for element in $list
do
    [[ "$element" == "$substring" ]] && return 0;
done

return -1;

}

readonly() { remote="$1" branch="$2"

if isin "$protected_remotes" "$remote" && isin "$protected_branches" "$branch"
then
    return 0;
else
    return -1;
fi

}

remote="$1"

IFS=" " while read local_ref local_sha remote_ref remote_sha do branch="$(echo $remote_ref | sed 's#^refs/heads/##g')" if readonly "$remote" "$branch" then echo "cannot push to $remote/$branch: protected branch. Use --no-verify to override this." exit -1 fi done ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  what is the best way to reset an unintentional direct push to the master 655382009
657213126 https://github.com/pydata/xarray/issues/4218#issuecomment-657213126 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxMzEyNg== keewis 14808389 2020-07-12T12:07:49Z 2020-07-12T12:10:35Z MEMBER

see this SO question. However, I don't think we should try that since there are a few cases where you still need to push without a PR (releasing, mainly). So I think either a pre-push hook or git config branch.master.pushRemote no_push (but then you also can't push to your own master anymore) are the best way forward

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  what is the best way to reset an unintentional direct push to the master 655382009
657211714 https://github.com/pydata/xarray/issues/4218#issuecomment-657211714 https://api.github.com/repos/pydata/xarray/issues/4218 MDEyOklzc3VlQ29tbWVudDY1NzIxMTcxNA== keewis 14808389 2020-07-12T11:54:41Z 2020-07-12T11:54:41Z MEMBER

oh, yeah. Then someone with the appropriate permissions (you? or maybe @shoyer?) has to temporarily remove the branch protection (settings on github), force push, and then add back the branch protection.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  what is the best way to reset an unintentional direct push to the master 655382009

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 1278.911ms · About: xarray-datasette