issue_comments

Table actions

8 rows where issue = 654678508 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Add initial cupy tests · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
657662153 https://github.com/pydata/xarray/pull/4214#issuecomment-657662153 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1NzY2MjE1Mw== jacobtomlinson 1610850 2020-07-13T16:31:34Z 2020-07-13T16:31:34Z CONTRIBUTOR

Nightlies are running. Sorry we can't do more than this right now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508
657627277 https://github.com/pydata/xarray/pull/4214#issuecomment-657627277 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1NzYyNzI3Nw== jacobtomlinson 1610850 2020-07-13T15:27:01Z 2020-07-13T15:27:01Z CONTRIBUTOR

Many thanks! We will start running nightlies from today. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508
657616206 https://github.com/pydata/xarray/pull/4214#issuecomment-657616206 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1NzYxNjIwNg== dcherian 2448579 2020-07-13T15:07:38Z 2020-07-13T15:07:38Z MEMBER

I'm merging so that @jacobtomlinson can keep moving forward.

It isn't breaking anything too :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508
656761038 https://github.com/pydata/xarray/pull/4214#issuecomment-656761038 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1Njc2MTAzOA== jacobtomlinson 1610850 2020-07-10T16:18:01Z 2020-07-10T16:18:01Z CONTRIBUTOR

Ok great! Once this is merged we will get that set up on our end.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508
656725555 https://github.com/pydata/xarray/pull/4214#issuecomment-656725555 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1NjcyNTU1NQ== dcherian 2448579 2020-07-10T15:09:07Z 2020-07-10T15:09:07Z MEMBER

run a nightly against the default branch on some GPU hardware. If the nightly fails we will open an issue and look into resolving it.

This is great! Thanks @jacobtomlinson 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508
656629069 https://github.com/pydata/xarray/pull/4214#issuecomment-656629069 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1NjYyOTA2OQ== jacobtomlinson 1610850 2020-07-10T11:34:37Z 2020-07-10T11:34:37Z CONTRIBUTOR

I think what we can offer at the moment is to run a nightly against the default branch on some GPU hardware. If the nightly fails we will open an issue and look into resolving it.

Not as neat as hooking into PRs like the rest of the CI though. Hopefully this will improve over time.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508
656613425 https://github.com/pydata/xarray/pull/4214#issuecomment-656613425 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1NjYxMzQyNQ== jacobtomlinson 1610850 2020-07-10T10:50:32Z 2020-07-10T10:50:32Z CONTRIBUTOR

@TomNicholas I've been trying to find a way to do this. In order for the cupy tests to be run the CI machine will need an NVIDIA GPU. But setting up a GPU CI would be a burden on the xarray team both technically and financially. This is why I'm just skipping for now.

For projects over in RAPIDS we have have a private GPU CI. We aren't in a position to integrate this here but we may be able to run nightlies. I'll update when I have more info.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508
656608745 https://github.com/pydata/xarray/pull/4214#issuecomment-656608745 https://api.github.com/repos/pydata/xarray/issues/4214 MDEyOklzc3VlQ29tbWVudDY1NjYwODc0NQ== TomNicholas 35968931 2020-07-10T10:37:53Z 2020-07-10T10:37:53Z MEMBER

Hi Jacob, would it make sense to add a new CI job that has cupy so that these tests actually get run automatically on future PRs? At the moment they're just going to get skipped, but if you're planning to work on this it might be a good idea to automate the cupy integration tests early on?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add initial cupy tests 654678508

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);