home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where issue = 645154872 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

  • keewis 4
  • shoyer 1
  • dcherian 1
  • max-sixty 1

issue 1

  • Consider revising our minimum dependency version policy · 7 ✖

author_association 1

  • MEMBER 7
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
778693569 https://github.com/pydata/xarray/issues/4179#issuecomment-778693569 https://api.github.com/repos/pydata/xarray/issues/4179 MDEyOklzc3VlQ29tbWVudDc3ODY5MzU2OQ== keewis 14808389 2021-02-13T23:33:52Z 2021-02-13T23:33:52Z MEMBER

ah, I seem to have missed that. Now that python has a yearly release cycle, I would extend the support window for a few months, though: with 24 months we could drop 3.8 as soon as 3.10 comes out (not sure if that's an issue in practice: projects like numba seem to take 4-5 months until they release a compatible version).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Consider revising our minimum dependency version policy 645154872
778686365 https://github.com/pydata/xarray/issues/4179#issuecomment-778686365 https://api.github.com/repos/pydata/xarray/issues/4179 MDEyOklzc3VlQ29tbWVudDc3ODY4NjM2NQ== shoyer 1217238 2021-02-13T22:21:34Z 2021-02-13T22:21:34Z MEMBER

If you look at the linked NumPy issue, I was also suggesting adjusting the number of months to compensate:

  • 24 months old Python
  • 18 months old NumPy

Those timeframes basically match up with those in the NumPy NEP.

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Consider revising our minimum dependency version policy 645154872
778681901 https://github.com/pydata/xarray/issues/4179#issuecomment-778681901 https://api.github.com/repos/pydata/xarray/issues/4179 MDEyOklzc3VlQ29tbWVudDc3ODY4MTkwMQ== keewis 14808389 2021-02-13T21:39:41Z 2021-02-13T21:42:56Z MEMBER

I wonder if finding a policy for all libraries is possible at all, and if maybe we should have a separate policy for python and numpy, which have a regular release cycle (every N months)?

That would mean: exactly 42 months support for python (together with packaging tools like pip and setuptools, should we depend on that) and exactly 18 months for numpy (as in "N months after the initial release we will stop supporting it"), but at least 12 or 6 months support for libraries like pandas, dask, scipy, and zarr which don't have frequent or regular releases ("the most recent minor version N months ago")

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Consider revising our minimum dependency version policy 645154872
778631437 https://github.com/pydata/xarray/issues/4179#issuecomment-778631437 https://api.github.com/repos/pydata/xarray/issues/4179 MDEyOklzc3VlQ29tbWVudDc3ODYzMTQzNw== keewis 14808389 2021-02-13T15:05:46Z 2021-02-13T20:02:19Z MEMBER

actually, this version of the policy won't work: if we require the most recent python version from 42 months ago (Aug 2017) we get python 3.6, which we can't maintain because most of our dependencies won't support it anymore by the time we would be allowed to drop it. So I think we will have to find a way to work around that, either by changing the support window of python or follow NEP29 and require at least M supported versions, or something completely different.

One edge case of the rules above would be if a package has no release for more than N months and then multiple releases over the course of a few weeks.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Consider revising our minimum dependency version policy 645154872
774323783 https://github.com/pydata/xarray/issues/4179#issuecomment-774323783 https://api.github.com/repos/pydata/xarray/issues/4179 MDEyOklzc3VlQ29tbWVudDc3NDMyMzc4Mw== keewis 14808389 2021-02-05T22:31:43Z 2021-02-05T22:31:43Z MEMBER

I think we talked about this in a meeting a few weeks ago, but I'm not sure I remember correctly: was the only issue that nobody picked this up? From the comments above it seems we all agree on changing the policy to "support the latest minor version (X.Y) available N months ago" – officially

the most recent minor version (X.Y) initially published more than N months ago

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Consider revising our minimum dependency version policy 645154872
651862338 https://github.com/pydata/xarray/issues/4179#issuecomment-651862338 https://api.github.com/repos/pydata/xarray/issues/4179 MDEyOklzc3VlQ29tbWVudDY1MTg2MjMzOA== dcherian 2448579 2020-06-30T15:19:41Z 2020-06-30T15:19:41Z MEMBER

"the most recent minor version (X.Y) initially published more than N months ago". This version makes a bit more sense to me: users only need to upgrade dependencies at least every N months to use the latest xarray release.

I agree.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Consider revising our minimum dependency version policy 645154872
649665604 https://github.com/pydata/xarray/issues/4179#issuecomment-649665604 https://api.github.com/repos/pydata/xarray/issues/4179 MDEyOklzc3VlQ29tbWVudDY0OTY2NTYwNA== max-sixty 5635139 2020-06-25T16:12:00Z 2020-06-25T16:12:00Z MEMBER

Agree, I was holding the same (incorrect) interpretation. Thanks for the excellent outline on the numpy tracker.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Consider revising our minimum dependency version policy 645154872

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 136.01ms · About: xarray-datasette