issue_comments

Table actions

4 rows where issue = 636666706 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • sparse upstream-dev test failures · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
801500388 https://github.com/pydata/xarray/issues/4146#issuecomment-801500388 https://api.github.com/repos/pydata/xarray/issues/4146 MDEyOklzc3VlQ29tbWVudDgwMTUwMDM4OA== keewis 14808389 2021-03-17T23:10:45Z 2021-03-17T23:10:45Z MEMBER

a small update on sparse: right now, enabling the install of sparse from github makes the upstream-dev CI fail on: xarray/tests/test_sparse.py::test_variable_method[obj.where(*(), **{'cond': <xarray.Variable (x: 10, y: 5)>\n<COO: shape=(10, 5), dtype=bool, nnz=3, fill_value=False>})-True] with a NEP18 error (numpy.allclose is not implemented for [<class 'numpy.ndarray'>, <class 'sparse._coo.core.COO'>])

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sparse upstream-dev test failures 636666706
644857262 https://github.com/pydata/xarray/issues/4146#issuecomment-644857262 https://api.github.com/repos/pydata/xarray/issues/4146 MDEyOklzc3VlQ29tbWVudDY0NDg1NzI2Mg== shoyer 1217238 2020-06-16T16:02:16Z 2020-06-16T16:02:16Z MEMBER

That's a good point, we should consider that! But we would really need a version of Numba built in a compatible way to the NumPy dev version we're using in order to make that feasible. For now I'm happy dropping sparse.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sparse upstream-dev test failures 636666706
644692632 https://github.com/pydata/xarray/issues/4146#issuecomment-644692632 https://api.github.com/repos/pydata/xarray/issues/4146 MDEyOklzc3VlQ29tbWVudDY0NDY5MjYzMg== keewis 14808389 2020-06-16T11:00:01Z 2020-06-16T11:00:01Z MEMBER

we don't even install a development version of sparse (maybe we should?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sparse upstream-dev test failures 636666706
644550723 https://github.com/pydata/xarray/issues/4146#issuecomment-644550723 https://api.github.com/repos/pydata/xarray/issues/4146 MDEyOklzc3VlQ29tbWVudDY0NDU1MDcyMw== shoyer 1217238 2020-06-16T06:04:49Z 2020-06-16T06:04:49Z MEMBER

It looks like all the sparse tests were passing on June 1, but are now failing.

Nothing remotely suspicious has been merged into pydata/sparse in the past 10 days, and I cannot reproduce these issues on my local machine.

But I did notice that the installed version of NumPy switched from 1.19.0rc2 to 1.20.0.dev. It seems quite plausible that this has resulted in some sort of binary incompatibility for NumPy and Numba.

For now, I'm simply going to remove sparse from our upstream dev tests. This isn't a subtle compatibility issue, so I'm going to let the Numba or sparse devs figure this out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sparse upstream-dev test failures 636666706

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);