issue_comments

Table actions

10 rows where issue = 634700536 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Fix: apply_ufunc with exclude_dims and vectorize · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
676492230 https://github.com/pydata/xarray/pull/4130#issuecomment-676492230 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjQ5MjIzMA== mathause 10194086 2020-08-19T15:20:56Z 2020-08-19T15:20:56Z MEMBER

Thanks @keewis!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676491787 https://github.com/pydata/xarray/pull/4130#issuecomment-676491787 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjQ5MTc4Nw== keewis 14808389 2020-08-19T15:20:12Z 2020-08-19T15:20:12Z MEMBER

the merge seems to have fixed it. Not sure why it didn't work before.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676443786 https://github.com/pydata/xarray/pull/4130#issuecomment-676443786 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjQ0Mzc4Ng== keewis 14808389 2020-08-19T14:25:10Z 2020-08-19T14:25:10Z MEMBER

thanks, @kmuehlbauer, good spot. However, that seems to come from the PR build (see also https://readthedocs.org/projects/xray/builds/11695402/, which doesn't fail), so I guess there has to be something in the code that changes the version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676430732 https://github.com/pydata/xarray/pull/4130#issuecomment-676430732 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjQzMDczMg== kmuehlbauer 5821660 2020-08-19T14:16:29Z 2020-08-19T14:16:29Z MEMBER

@keewis In the xarray setup there is --prune-tags. In your setup this is not there. Not sure, if this might be connected. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676423524 https://github.com/pydata/xarray/pull/4130#issuecomment-676423524 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjQyMzUyNA== keewis 14808389 2020-08-19T14:11:51Z 2020-08-19T14:11:51Z MEMBER

on my own setup the build completes: https://readthedocs.org/projects/xarray-keewis/builds/11696307/ So this is definitely an issue with the setup, but I don't know how to fix that...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676390398 https://github.com/pydata/xarray/pull/4130#issuecomment-676390398 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjM5MDM5OA== mathause 10194086 2020-08-19T13:49:54Z 2020-08-19T13:49:54Z MEMBER

But unfortunately this doesn't help :( If you have another idea I am all ears. But anyways it should not stop anyone from reviewing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676334438 https://github.com/pydata/xarray/pull/4130#issuecomment-676334438 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjMzNDQzOA== mathause 10194086 2020-08-19T13:12:42Z 2020-08-19T13:12:42Z MEMBER

Thanks keewis! I don't think I would have figured that out. I pushed the tags to my fork. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676226637 https://github.com/pydata/xarray/pull/4130#issuecomment-676226637 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjIyNjYzNw== keewis 14808389 2020-08-19T11:57:06Z 2020-08-19T12:01:02Z MEMBER

The readthedocs error is a timeout

Unfortunately not. The build timed out after the error and the traceback is visible. My own setup doesn't time out on errors, so I asked support to help fix that. They removed stale memory constraints (which is why the traceback is visible), but somehow the build still times out on errors.

In this case pandas has a minimum version requirement for xarray, but the detected version is 0.1. I'm not sure why version detection works for me but not for you, maybe because you didn't update the tags on your repo in a long time?

Edit: to re-trigger RTD, we have to close and reopen the PR; they don't allow rerunning a PR build

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
676204299 https://github.com/pydata/xarray/pull/4130#issuecomment-676204299 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY3NjIwNDI5OQ== mathause 10194086 2020-08-19T11:40:43Z 2020-08-19T11:40:43Z MEMBER

Inplemented @shoyer's suggestion to add exclude_dims as optional argument to to_gufunc_string. The readthedocs error is a timeout so should be fine to review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536
643967598 https://github.com/pydata/xarray/pull/4130#issuecomment-643967598 https://api.github.com/repos/pydata/xarray/issues/4130 MDEyOklzc3VlQ29tbWVudDY0Mzk2NzU5OA== mathause 10194086 2020-06-15T07:57:18Z 2020-06-15T07:57:18Z MEMBER

Sounds good. I can move _enumerate into to_gufunc_string. I think it makes sense to wait for #4060.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix: apply_ufunc with exclude_dims and vectorize 634700536

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);