issue_comments

Table actions

9 rows where issue = 631860723 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • upstream-dev CI fails on import of dask.array · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
641980411 https://github.com/pydata/xarray/issues/4124#issuecomment-641980411 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MTk4MDQxMQ== keewis 14808389 2020-06-10T12:41:44Z 2020-06-10T12:41:44Z MEMBER

dask==2.18.1 has been released so I'm closing this

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
641592362 https://github.com/pydata/xarray/issues/4124#issuecomment-641592362 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MTU5MjM2Mg== shoyer 1217238 2020-06-09T21:29:39Z 2020-06-09T21:29:39Z MEMBER

I would suggest pinning dask for now (or waiting until the new release).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
641587033 https://github.com/pydata/xarray/issues/4124#issuecomment-641587033 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MTU4NzAzMw== jsignell 4806877 2020-06-09T21:18:42Z 2020-06-09T21:18:42Z CONTRIBUTOR

I think dask is going to release today.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
641543765 https://github.com/pydata/xarray/issues/4124#issuecomment-641543765 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MTU0Mzc2NQ== dcherian 2448579 2020-06-09T20:12:02Z 2020-06-09T20:12:02Z MEMBER

or remove the -OO option in the CI. Does anyone know why we use that option?

Looks like @shoyer added that line initially. Lets try removing it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
640842235 https://github.com/pydata/xarray/issues/4124#issuecomment-640842235 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MDg0MjIzNQ== keewis 14808389 2020-06-08T19:36:41Z 2020-06-08T23:04:54Z MEMBER

the fix by @jsignell is now on dask master so the upstream-dev CI should work, but our other CI will keep failing until dask=2.18.1 or dask=2.19.0 is released.

In the meantime, we could pin dask to dask!=2.18.0 or remove the -OO option in the CI. Does anyone know why we use that option?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
640705525 https://github.com/pydata/xarray/issues/4124#issuecomment-640705525 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MDcwNTUyNQ== dcherian 2448579 2020-06-08T15:34:56Z 2020-06-08T15:34:56Z MEMBER

Awesome. Thanks @jsignell 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
640703229 https://github.com/pydata/xarray/issues/4124#issuecomment-640703229 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MDcwMzIyOQ== jsignell 4806877 2020-06-08T15:30:55Z 2020-06-08T15:31:18Z CONTRIBUTOR

Working on a fix now. I think https://github.com/dask/dask/pull/6299 should do it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
640691843 https://github.com/pydata/xarray/issues/4124#issuecomment-640691843 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MDY5MTg0Mw== dcherian 2448579 2020-06-08T15:11:34Z 2020-06-08T15:11:34Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   upstream-dev CI fails on import of dask.array 631860723
640127499 https://github.com/pydata/xarray/issues/4124#issuecomment-640127499 https://api.github.com/repos/pydata/xarray/issues/4124 MDEyOklzc3VlQ29tbWVudDY0MDEyNzQ5OQ== keewis 14808389 2020-06-06T22:42:37Z 2020-06-06T22:42:37Z MEMBER

It seems that's because we use python -OO -c "import xarray" to test importing, and the optimization (no asserts / __debug__ related stuff) makes import dask.array fail.

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 2
}
   upstream-dev CI fails on import of dask.array 631860723

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);