issue_comments

Table actions

3 rows where issue = 623230375 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix conversion of multiindexed pandas objects to sparse xarray objects · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
634311032 https://github.com/pydata/xarray/pull/4088#issuecomment-634311032 https://api.github.com/repos/pydata/xarray/issues/4088 MDEyOklzc3VlQ29tbWVudDYzNDMxMTAzMg== dcherian 2448579 2020-05-26T22:19:58Z 2020-05-26T22:19:58Z MEMBER

Thanks for the reviews

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix conversion of multiindexed pandas objects to sparse xarray objects 623230375
633737367 https://github.com/pydata/xarray/pull/4088#issuecomment-633737367 https://api.github.com/repos/pydata/xarray/issues/4088 MDEyOklzc3VlQ29tbWVudDYzMzczNzM2Nw== dcherian 2448579 2020-05-25T23:01:06Z 2020-05-25T23:01:06Z MEMBER

Ready for review. I added a test that checks if the coords for the underlying sparse object are the same when created in two ways 1. from_series(..., sparse=False).data converted to sparse using sparse.COO.from_numpy 2. from_series(..., sparse=True).data

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix conversion of multiindexed pandas objects to sparse xarray objects 623230375
632704318 https://github.com/pydata/xarray/pull/4088#issuecomment-632704318 https://api.github.com/repos/pydata/xarray/issues/4088 MDEyOklzc3VlQ29tbWVudDYzMjcwNDMxOA== pep8speaks 24736507 2020-05-22T13:59:32Z 2020-05-25T22:59:09Z NONE

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-05-25 22:59:09 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix conversion of multiindexed pandas objects to sparse xarray objects 623230375

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);