issue_comments
23 rows where issue = 618828102 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- Auto chunk · 23 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
633710066 | https://github.com/pydata/xarray/pull/4064#issuecomment-633710066 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYzMzcxMDA2Ng== | AndrewILWilliams 56925856 | 2020-05-25T20:38:49Z | 2020-05-25T20:38:49Z | CONTRIBUTOR | No problem ! Thanks everyone for helping me get up to speed :) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
633691103 | https://github.com/pydata/xarray/pull/4064#issuecomment-633691103 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYzMzY5MTEwMw== | dcherian 2448579 | 2020-05-25T19:20:52Z | 2020-05-25T19:20:52Z | MEMBER | Thanks @AndrewWilliams3142 |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629197669 | https://github.com/pydata/xarray/pull/4064#issuecomment-629197669 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE5NzY2OQ== | pep8speaks 24736507 | 2020-05-15T12:06:03Z | 2020-05-21T17:16:39Z | NONE | Hello @AndrewWilliams3142! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: Comment last updated at 2020-05-21 17:16:39 UTC |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
632128807 | https://github.com/pydata/xarray/pull/4064#issuecomment-632128807 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYzMjEyODgwNw== | AndrewILWilliams 56925856 | 2020-05-21T14:49:37Z | 2020-05-21T14:49:37Z | CONTRIBUTOR | @keewis thanks for this! I've added what I think is a suitable test for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
632093104 | https://github.com/pydata/xarray/pull/4064#issuecomment-632093104 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYzMjA5MzEwNA== | keewis 14808389 | 2020-05-21T13:42:08Z | 2020-05-21T13:42:08Z | MEMBER |
|
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
632090407 | https://github.com/pydata/xarray/pull/4064#issuecomment-632090407 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYzMjA5MDQwNw== | AndrewILWilliams 56925856 | 2020-05-21T13:36:41Z | 2020-05-21T13:36:41Z | CONTRIBUTOR |
@dcherian Thanks for the tip:) Quick question: Is there a reason why you're specifying the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
632035116 | https://github.com/pydata/xarray/pull/4064#issuecomment-632035116 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYzMjAzNTExNg== | AndrewILWilliams 56925856 | 2020-05-21T11:30:01Z | 2020-05-21T11:30:01Z | CONTRIBUTOR | Cheers! I forgot about the tests, will add them this week or next hopefully |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
631604681 | https://github.com/pydata/xarray/pull/4064#issuecomment-631604681 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYzMTYwNDY4MQ== | dcherian 2448579 | 2020-05-20T17:05:41Z | 2020-05-20T17:05:41Z | MEMBER | Thanks @AndrewWilliams3142 . We should add a test for |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629390609 | https://github.com/pydata/xarray/pull/4064#issuecomment-629390609 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTM5MDYwOQ== | AndrewILWilliams 56925856 | 2020-05-15T17:40:39Z | 2020-05-15T17:41:25Z | CONTRIBUTOR | @dcherian do you have any idea about this
Edit: thanks to everyone for your help so far! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629355884 | https://github.com/pydata/xarray/pull/4064#issuecomment-629355884 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTM1NTg4NA== | dcherian 2448579 | 2020-05-15T16:28:14Z | 2020-05-15T16:28:14Z | MEMBER | ah right. this is now rechunking chunked objects to a single chunk when |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629346101 | https://github.com/pydata/xarray/pull/4064#issuecomment-629346101 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTM0NjEwMQ== | AndrewILWilliams 56925856 | 2020-05-15T16:11:04Z | 2020-05-15T16:22:24Z | CONTRIBUTOR | Okay so I've traced the error back to the Normally, when using the ```python
However, when I use the changes I've made to ```python
Which means that it now fails the I've tried to follow through the code and see what is actually happening when this change is made, but I'm out of my depth here. My guess is that Edit: I think that's the problem!
I'll add in something to catch |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629199017 | https://github.com/pydata/xarray/pull/4064#issuecomment-629199017 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE5OTAxNw== | keewis 14808389 | 2020-05-15T12:09:18Z | 2020-05-15T12:12:05Z | MEMBER | then you'll have to run For future reference, github does not work terribly well with rebases (or merges without a merge commit) so it would be good to avoid those. Edit: ignore the |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629197362 | https://github.com/pydata/xarray/pull/4064#issuecomment-629197362 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE5NzM2Mg== | AndrewILWilliams 56925856 | 2020-05-15T12:05:22Z | 2020-05-15T12:05:22Z | CONTRIBUTOR | No unpushed commits |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629192230 | https://github.com/pydata/xarray/pull/4064#issuecomment-629192230 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE5MjIzMA== | keewis 14808389 | 2020-05-15T11:52:27Z | 2020-05-15T11:52:27Z | MEMBER | if you have any unpushed commits: could you push them now? While they would not be lost, it's way easier to handle them now than after the force-push |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629191037 | https://github.com/pydata/xarray/pull/4064#issuecomment-629191037 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE5MTAzNw== | AndrewILWilliams 56925856 | 2020-05-15T11:49:23Z | 2020-05-15T11:49:23Z | CONTRIBUTOR | Do you mean the master merge? If that's wrong would you be able to fix it for me? My bad, hopefully i'll be able to do it more cleanly in future |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629189848 | https://github.com/pydata/xarray/pull/4064#issuecomment-629189848 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE4OTg0OA== | keewis 14808389 | 2020-05-15T11:46:09Z | 2020-05-15T11:46:09Z | MEMBER | there's something wrong with the merge. Are you able to resolve that by yourself, or should I fix it for you? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629171237 | https://github.com/pydata/xarray/pull/4064#issuecomment-629171237 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE3MTIzNw== | keewis 14808389 | 2020-05-15T10:57:29Z | 2020-05-15T11:01:53Z | MEMBER | no, the If you need more explanations on Edit: the book even has a section on Github |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629168282 | https://github.com/pydata/xarray/pull/4064#issuecomment-629168282 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE2ODI4Mg== | AndrewILWilliams 56925856 | 2020-05-15T10:49:43Z | 2020-05-15T10:49:43Z | CONTRIBUTOR | Okay, that makes sense. Though, it seems that I forked the master branch before @kmuehlbauer's commit, which fixed this flake8 issue? So I think I need to make a new fork? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629162166 | https://github.com/pydata/xarray/pull/4064#issuecomment-629162166 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE2MjE2Ng== | keewis 14808389 | 2020-05-15T10:33:56Z | 2020-05-15T10:33:56Z | MEMBER | to merge |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629154336 | https://github.com/pydata/xarray/pull/4064#issuecomment-629154336 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE1NDMzNg== | AndrewILWilliams 56925856 | 2020-05-15T10:15:50Z | 2020-05-15T10:17:38Z | CONTRIBUTOR | Okay cheers both! I'll have a look at these now. @keewis sorry I'm still getting used to using this side of Git at the moment, could you clarify what you mean by merge |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629149680 | https://github.com/pydata/xarray/pull/4064#issuecomment-629149680 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE0OTY4MA== | keewis 14808389 | 2020-05-15T10:04:58Z | 2020-05-15T10:09:13Z | MEMBER | no need to rebase, simply merge Edit: the failing |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629149164 | https://github.com/pydata/xarray/pull/4064#issuecomment-629149164 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE0OTE2NA== | kmuehlbauer 5821660 | 2020-05-15T10:03:42Z | 2020-05-15T10:03:42Z | MEMBER |
@AndrewWilliams3142 This is due to flake8 applying new changes from pycodestyle. xarray-devs already dived into this, see https://github.com/pydata/xarray/pull/4057. You might just need to rebase with current master, to make the error go away. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 | |
629147818 | https://github.com/pydata/xarray/pull/4064#issuecomment-629147818 | https://api.github.com/repos/pydata/xarray/issues/4064 | MDEyOklzc3VlQ29tbWVudDYyOTE0NzgxOA== | AndrewILWilliams 56925856 | 2020-05-15T10:00:35Z | 2020-05-15T10:01:43Z | CONTRIBUTOR | In my git clone, when I run the
I'm not sure why something has changed in these files (I haven't touched them), I also can't work out what the Could this somehow be associated with loads of the checks failing below? Thanks! :) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Auto chunk 618828102 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 5