issue_comments

Table actions

9 rows where issue = 614854414 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • improve to_zarr doc about chunking · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
631661290 https://github.com/pydata/xarray/pull/4048#issuecomment-631661290 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYzMTY2MTI5MA== shoyer 1217238 2020-05-20T18:55:38Z 2020-05-20T18:55:38Z MEMBER

thanks @apatlpo !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
631660983 https://github.com/pydata/xarray/pull/4048#issuecomment-631660983 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYzMTY2MDk4Mw== shoyer 1217238 2020-05-20T18:55:08Z 2020-05-20T18:55:08Z MEMBER

I think it's OK that it's not formatted as a list. It's still pretty readable

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
631479782 https://github.com/pydata/xarray/pull/4048#issuecomment-631479782 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYzMTQ3OTc4Mg== apatlpo 11750960 2020-05-20T13:39:25Z 2020-05-20T13:39:25Z CONTRIBUTOR

argh ... saved_on_disk.nc has been removed.

I was unfortunately not able to create a proper list without breaking tests and have exhausted my time trying to figure it out. If you know how to do that I am more than happy to follow your advice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
625904755 https://github.com/pydata/xarray/pull/4048#issuecomment-625904755 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYyNTkwNDc1NQ== pep8speaks 24736507 2020-05-08T16:43:13Z 2020-05-20T13:37:27Z NONE

Hello @apatlpo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-05-20 13:37:26 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
631471954 https://github.com/pydata/xarray/pull/4048#issuecomment-631471954 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYzMTQ3MTk1NA== keewis 14808389 2020-05-20T13:25:24Z 2020-05-20T13:25:24Z MEMBER

they do, but could you remove the saved_on_disk.nc file that was accidentally added?

Also, the items are not a list despite being formatted like one: is that intentional?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
631461955 https://github.com/pydata/xarray/pull/4048#issuecomment-631461955 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYzMTQ2MTk1NQ== apatlpo 11750960 2020-05-20T13:07:25Z 2020-05-20T13:07:25Z CONTRIBUTOR

ok, tests are passing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
629425081 https://github.com/pydata/xarray/pull/4048#issuecomment-629425081 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYyOTQyNTA4MQ== keewis 14808389 2020-05-15T18:58:43Z 2020-05-15T23:11:35Z MEMBER

the flake8 issues are fixed in #4057, so you can merge master into your branch to fix them in this branch, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
629419326 https://github.com/pydata/xarray/pull/4048#issuecomment-629419326 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYyOTQxOTMyNg== rabernat 1197350 2020-05-15T18:45:57Z 2020-05-15T18:45:57Z MEMBER

There are two sphinx warnings in building the docs https://dev.azure.com/xarray/xarray/_build/results?buildId=2819&view=logs&j=7e620c85-24a8-5ffa-8b1f-642bc9b1fc36&t=68484831-0a19-5145-bfe9-6309e5f7691d&l=280

xarray/core/dataset.py:docstring of xarray.Dataset.to_zarr:44: WARNING: Definition list ends without a blank line; unexpected unindent. xarray/core/dataset.py:docstring of xarray.Dataset.to_zarr:46: WARNING: Unexpected indentation.

These seem related to your changes. I would try to get the docs building locally without any warnings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414
629416035 https://github.com/pydata/xarray/pull/4048#issuecomment-629416035 https://api.github.com/repos/pydata/xarray/issues/4048 MDEyOklzc3VlQ29tbWVudDYyOTQxNjAzNQ== apatlpo 11750960 2020-05-15T18:38:20Z 2020-05-15T18:38:20Z CONTRIBUTOR

if anybody has a clue on how to fix tests this would be welcome. thx

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   improve to_zarr doc about chunking 614854414

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);