issue_comments

Table actions

16 rows where issue = 613579881 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • expanded HTML repr when opening notebook · 16 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
627095207 https://github.com/pydata/xarray/issues/4041#issuecomment-627095207 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNzA5NTIwNw== shoyer 1217238 2020-05-12T04:04:27Z 2020-05-12T04:04:27Z MEMBER

I’ve seen similar issues with the seeing unformatted CSS in notebooks on Github. I do think some sort of fallback to pure text mode would be great if we could make it work...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626908469 https://github.com/pydata/xarray/issues/4041#issuecomment-626908469 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjkwODQ2OQ== benbovy 4160723 2020-05-11T19:26:06Z 2020-05-11T19:26:06Z MEMBER

Maybe we could use some sort of hack with HTML hidden attribute and some CSS, in order to show the plain text repr when CSS is not injected... Not ideal but at least it would be better than the HTML repr shown without CSS style.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626905024 https://github.com/pydata/xarray/issues/4041#issuecomment-626905024 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjkwNTAyNA== jsignell 4806877 2020-05-11T19:19:51Z 2020-05-11T19:19:51Z CONTRIBUTOR

Yes that seems like the explanation. Thanks @benbovy! I would expect dask to have the same behavior then since they pass in the style tag in the same way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626900556 https://github.com/pydata/xarray/issues/4041#issuecomment-626900556 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjkwMDU1Ng== benbovy 4160723 2020-05-11T19:11:24Z 2020-05-11T19:11:24Z MEMBER 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626869393 https://github.com/pydata/xarray/issues/4041#issuecomment-626869393 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjg2OTM5Mw== jsignell 4806877 2020-05-11T18:16:36Z 2020-05-11T18:16:36Z CONTRIBUTOR

Hmm. Ok. I'm still not sure why the html would get messed up under that scenario though. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626863781 https://github.com/pydata/xarray/issues/4041#issuecomment-626863781 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjg2Mzc4MQ== dcherian 2448579 2020-05-11T18:06:10Z 2020-05-11T18:06:10Z MEMBER

oh yes that is quite likely.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626860177 https://github.com/pydata/xarray/issues/4041#issuecomment-626860177 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjg2MDE3Nw== jsignell 4806877 2020-05-11T17:59:49Z 2020-05-11T17:59:49Z CONTRIBUTOR

Does it seem possible that you had originally run it in jlab and then opened it in notebook or vice versa? I've seen html output get kind of messed up under those conditions, but I've never really stopped to debug it thoroughly. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626853375 https://github.com/pydata/xarray/issues/4041#issuecomment-626853375 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjg1MzM3NQ== dcherian 2448579 2020-05-11T17:47:59Z 2020-05-11T17:47:59Z MEMBER

Yes the repr works perfectly when re-running these cells. The issue here is when I open an existing notebook with reprs in output cells.

I am on firefox beta :/ but yes it could be a jupyterlab thing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626848249 https://github.com/pydata/xarray/issues/4041#issuecomment-626848249 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjg0ODI0OQ== jsignell 4806877 2020-05-11T17:39:12Z 2020-05-11T17:39:12Z CONTRIBUTOR

It seems like the auto-update thing works for css, but not for icons.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626846717 https://github.com/pydata/xarray/issues/4041#issuecomment-626846717 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjg0NjcxNw== jsignell 4806877 2020-05-11T17:36:33Z 2020-05-11T17:36:33Z CONTRIBUTOR

Huh and if you re-run cell 69 does it render correctly? I'm on chrome 80, but if you were seeing this in firefox as well it seems like it's more likely to be a jupyterlab thing. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626828901 https://github.com/pydata/xarray/issues/4041#issuecomment-626828901 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjgyODkwMQ== dcherian 2448579 2020-05-11T17:04:09Z 2020-05-11T17:04:09Z MEMBER

Thanks for taking a look @jsignell. Here are some notes I made while trying to reproduce.

  1. I cannot reproduce at all locally with the same browsers. This problem may only occur with ssh tunneling. I tunnel to a remote machine; start a jupyter server; and then connect through a tunnel to that server. The next two points are about the remote notebook.

  2. Looks like there is no style attribute (this is from an older notebook with the problem)

There are two output cells with reprs, both of which are not styled correctly.

  1. Now I run the first cell.

The first cell looks right (and has a style attribute). The second one has auto-updated and looks OK but is missing the style attribute, as well as the click-to-show-data-values functionality.

This "auto updating" behaviour is new i.e. wasn't happening last week. I'm on chrome 81 now so maybe all of this is just browser weirdness?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626721909 https://github.com/pydata/xarray/issues/4041#issuecomment-626721909 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjcyMTkwOQ== jsignell 4806877 2020-05-11T14:04:31Z 2020-05-11T14:04:31Z CONTRIBUTOR

I can't reproduce:

Tried on chrome and firefox on linux. Can you inspect the element in your browser console and see if there is a <style></style> section for the repr? It seems like that might not be getting in properly

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626712595 https://github.com/pydata/xarray/issues/4041#issuecomment-626712595 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjcxMjU5NQ== jsignell 4806877 2020-05-11T13:47:44Z 2020-05-11T13:47:44Z CONTRIBUTOR

Yeah I can take a look now. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
626189120 https://github.com/pydata/xarray/issues/4041#issuecomment-626189120 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNjE4OTEyMA== dcherian 2448579 2020-05-09T15:02:37Z 2020-05-09T15:02:37Z MEMBER

Maybe @jsignell can help fix this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
624990305 https://github.com/pydata/xarray/issues/4041#issuecomment-624990305 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNDk5MDMwNQ== jkmacc-LANL 6475152 2020-05-07T02:20:39Z 2020-05-07T02:20:39Z NONE

Same here, Firefox on a Mac.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881
624905520 https://github.com/pydata/xarray/issues/4041#issuecomment-624905520 https://api.github.com/repos/pydata/xarray/issues/4041 MDEyOklzc3VlQ29tbWVudDYyNDkwNTUyMA== aaronspring 12237157 2020-05-06T21:39:55Z 2020-05-06T21:39:55Z CONTRIBUTOR

me too on Firefox linux 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   expanded HTML repr when opening notebook 613579881

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);