issue_comments

Table actions

9 rows where issue = 612785915 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • 0.16.0 release · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
658323614 https://github.com/pydata/xarray/issues/4031#issuecomment-658323614 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY1ODMyMzYxNA== dcherian 2448579 2020-07-14T17:54:31Z 2020-07-14T17:54:31Z MEMBER

Thanks @max-sixty !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
655037306 https://github.com/pydata/xarray/issues/4031#issuecomment-655037306 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY1NTAzNzMwNg== max-sixty 5635139 2020-07-07T18:15:38Z 2020-07-07T18:15:38Z MEMBER

FYI I will do this towards the end of this week or at the latest this weekend

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
653272781 https://github.com/pydata/xarray/issues/4031#issuecomment-653272781 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY1MzI3Mjc4MQ== max-sixty 5635139 2020-07-03T00:33:59Z 2020-07-03T00:33:59Z MEMBER

Re: #3891 do you mean set keep_attrs=True by default?

Exactly, so this will push to 0.17

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
653221505 https://github.com/pydata/xarray/issues/4031#issuecomment-653221505 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY1MzIyMTUwNQ== dcherian 2448579 2020-07-02T21:09:35Z 2020-07-02T21:09:45Z MEMBER

I'd vote to leave it until we have a repro.

:+1: I'm also not sure what the bug is. In fact it's possible that a bug was fixed and a workaround is what's raising the error now :P

Re: #3891 do you mean set keep_attrs=True by default?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
653218817 https://github.com/pydata/xarray/issues/4031#issuecomment-653218817 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY1MzIxODgxNw== max-sixty 5635139 2020-07-02T21:02:06Z 2020-07-02T21:02:06Z MEMBER

Thanks for updating @dcherian . Is it worth waiting for #3985? I'm still not sure exactly what the bug is there. I'd vote to leave it until we have a repro.

I was thinking of sneaking in https://github.com/pydata/xarray/issues/3891 but didn't want to bring it up as probably won't be able to; definitely not worth waiting on me for!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
651874554 https://github.com/pydata/xarray/issues/4031#issuecomment-651874554 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY1MTg3NDU1NA== max-sixty 5635139 2020-06-30T15:38:38Z 2020-06-30T15:38:38Z MEMBER

Agree! I'll keep an eye on those this week. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
651387910 https://github.com/pydata/xarray/issues/4031#issuecomment-651387910 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY1MTM4NzkxMA== dcherian 2448579 2020-06-29T21:50:06Z 2020-06-29T21:50:06Z MEMBER

Yes we have some breaking changes so definitely 0.16.0

IMO we should do #4184 #4175 and #4163 and then release. #3985 is still waiting for a minimal example so perhaps we should leave that for the next release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
649798109 https://github.com/pydata/xarray/issues/4031#issuecomment-649798109 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDY0OTc5ODEwOQ== max-sixty 5635139 2020-06-25T20:22:51Z 2020-06-25T20:22:51Z MEMBER

As discussed on the dev call, I'll take this one.

I think we need to do 0.16.0 as we had some backward-incompat changes (I can't remember now what they were; but can hunt them down if anyone otherwise has a preference for 0.15.2?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915
630369063 https://github.com/pydata/xarray/issues/4031#issuecomment-630369063 https://api.github.com/repos/pydata/xarray/issues/4031 MDEyOklzc3VlQ29tbWVudDYzMDM2OTA2Mw== mathause 10194086 2020-05-18T18:45:05Z 2020-06-15T08:01:05Z MEMBER
  • [x] #4075 passing boolean weights to weighted mean
  • [ ] #4060 dask.array.apply_gufunc in xr.apply_ufunc (supersedes #4022)
  • [ ] #4130 apply_ufunc with vectorize and exclude_dims
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   0.16.0 release 612785915

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);