issue_comments

Table actions

6 rows where issue = 611643130 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • small contrast of html view in VScode darkmode · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
624438211 https://github.com/pydata/xarray/issues/4024#issuecomment-624438211 https://api.github.com/repos/pydata/xarray/issues/4024 MDEyOklzc3VlQ29tbWVudDYyNDQzODIxMQ== fujiisoup 6815844 2020-05-06T04:42:08Z 2020-05-06T04:42:08Z MEMBER

Thanks, @shoyer and @DocOtak for the suggestions.

It looks like there may be some standard ways to detect dark vs light mode in CSS? https://medium.com/js-dojo/how-to-enable-dark-mode-on-your-website-with-pure-css-32640335474

It looks not working in vscode...

VS Code will tell you if it is in "dark" "light" or "high contrast" modes https://code.visualstudio.com/api/extension-guides/webview#theming-webview-content

In #4036 I used css body.vscode-dark { } code block, but maybe more general solution would be better if available...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   small contrast of html view in VScode darkmode 611643130
624408302 https://github.com/pydata/xarray/issues/4024#issuecomment-624408302 https://api.github.com/repos/pydata/xarray/issues/4024 MDEyOklzc3VlQ29tbWVudDYyNDQwODMwMg== DocOtak 868027 2020-05-06T02:19:09Z 2020-05-06T02:19:09Z CONTRIBUTOR

VS Code will tell you if it is in "dark" "light" or "high contrast" modes https://code.visualstudio.com/api/extension-guides/webview#theming-webview-content

Looks like there is an upstream issue which might prevent getting the actual theme colors in some situations: https://github.com/microsoft/vscode-python/issues/9597

For my own stuff in VS Code, I usually disable the HTML repr in those notebooks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   small contrast of html view in VScode darkmode 611643130
624403030 https://github.com/pydata/xarray/issues/4024#issuecomment-624403030 https://api.github.com/repos/pydata/xarray/issues/4024 MDEyOklzc3VlQ29tbWVudDYyNDQwMzAzMA== shoyer 1217238 2020-05-06T01:54:52Z 2020-05-06T01:54:52Z MEMBER

It looks like there may be some standard ways to detect dark vs light mode in CSS? https://medium.com/js-dojo/how-to-enable-dark-mode-on-your-website-with-pure-css-32640335474

I'm not sure if those work in IDEs like VSCode and Google Colab, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   small contrast of html view in VScode darkmode 611643130
624359804 https://github.com/pydata/xarray/issues/4024#issuecomment-624359804 https://api.github.com/repos/pydata/xarray/issues/4024 MDEyOklzc3VlQ29tbWVudDYyNDM1OTgwNA== fujiisoup 6815844 2020-05-05T23:31:26Z 2020-05-05T23:31:26Z MEMBER

It looks that Pandas is taking a very different approach and codebase and I don't think it is easy to adapt their approach...

I am not familiar with the css staff in jupyter but the simplest approach may be just to disable the text- and background-coloring but use the default color only. Then, our html repr becomes less pretty but maybe more robust.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   small contrast of html view in VScode darkmode 611643130
624350348 https://github.com/pydata/xarray/issues/4024#issuecomment-624350348 https://api.github.com/repos/pydata/xarray/issues/4024 MDEyOklzc3VlQ29tbWVudDYyNDM1MDM0OA== fujiisoup 6815844 2020-05-05T23:00:30Z 2020-05-05T23:00:30Z MEMBER

pandas has a good style. We may be able to take it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   small contrast of html view in VScode darkmode 611643130
624338446 https://github.com/pydata/xarray/issues/4024#issuecomment-624338446 https://api.github.com/repos/pydata/xarray/issues/4024 MDEyOklzc3VlQ29tbWVudDYyNDMzODQ0Ng== fujiisoup 6815844 2020-05-05T22:24:04Z 2020-05-05T22:24:04Z MEMBER

It is how it looks like in Light mode

Here is the css definition https://github.com/pydata/xarray/blob/59b470f5d1464366dc55b082618ea87da8fbc9af/xarray/static/css/style.css#L5-L14

It looks like that --jp-content-font-color0 and --jp-layout-color0 come from the theme but the others come from our default values. I have no idea yet how we can manage this...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   small contrast of html view in VScode darkmode 611643130

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);