issue_comments

Table actions

14 rows where issue = 611238092 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Allow passing axis kwargs to plot · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
653215094 https://github.com/pydata/xarray/pull/4020#issuecomment-653215094 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY1MzIxNTA5NA== dcherian 2448579 2020-07-02T20:51:51Z 2020-07-02T20:51:51Z MEMBER

@raphaeldussin thanks for your patience here. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
652488714 https://github.com/pydata/xarray/pull/4020#issuecomment-652488714 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY1MjQ4ODcxNA== raphaeldussin 14662821 2020-07-01T15:30:42Z 2020-07-01T15:30:42Z CONTRIBUTOR

@dcherian thanks for the final fixes!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
629692631 https://github.com/pydata/xarray/pull/4020#issuecomment-629692631 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDYyOTY5MjYzMQ== pep8speaks 24736507 2020-05-16T19:06:57Z 2020-07-01T15:16:03Z NONE

Hello @raphaeldussin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-07-01 15:16:02 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
651387220 https://github.com/pydata/xarray/pull/4020#issuecomment-651387220 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY1MTM4NzIyMA== dcherian 2448579 2020-06-29T21:48:34Z 2020-06-29T21:48:34Z MEMBER

this should be good to go when tests pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
649680783 https://github.com/pydata/xarray/pull/4020#issuecomment-649680783 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY0OTY4MDc4Mw== keewis 14808389 2020-06-25T16:39:39Z 2020-06-25T16:39:39Z MEMBER

@mathause: yep, that seems to be restricted to maintainers and pull request authors, so if someone reviewed without being a maintainer they won't be able to change the resolve status of their own comments. Also, there doesn't seem to be a setting to change this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
649666135 https://github.com/pydata/xarray/pull/4020#issuecomment-649666135 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY0OTY2NjEzNQ== raphaeldussin 14662821 2020-06-25T16:12:27Z 2020-06-25T16:12:27Z CONTRIBUTOR

Looks good to me - thanks.

The "resolve conversation" button seems to have disappeared... so I cannot close the comments that are no longer relevant.

pinging @keewis @dcherian

I can see the "resolve conversation" buttons, do you want me to close them?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
648949820 https://github.com/pydata/xarray/pull/4020#issuecomment-648949820 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY0ODk0OTgyMA== raphaeldussin 14662821 2020-06-24T17:12:16Z 2020-06-24T17:12:16Z CONTRIBUTOR

would it make sense to update the documentation here: http://xarray.pydata.org/en/stable/plotting.html#maps

the update would be:

```diff - ax = plt.axes(projection=ccrs.Orthographic(-80, 35)) - air.isel(time=0).plot.contourf(ax=ax, transform=ccrs.PlateCarree()) - ax.set_global() + p = air.isel(time=0).plot(projection=ccrs.Orthographic(-80, 35), + transform=ccrs.PlateCarree()) + p.axes.set_global()

 @savefig plotting_maps_cartopy.png width=100%
  • ax.coastlines()
  • p.axes.coastlines() ```
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
648447234 https://github.com/pydata/xarray/pull/4020#issuecomment-648447234 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY0ODQ0NzIzNA== keewis 14808389 2020-06-23T21:51:55Z 2020-06-23T21:51:55Z MEMBER

thanks, looks good to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
648440945 https://github.com/pydata/xarray/pull/4020#issuecomment-648440945 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY0ODQ0MDk0NQ== raphaeldussin 14662821 2020-06-23T21:35:57Z 2020-06-23T21:35:57Z CONTRIBUTOR

@keewis thank you for the review. I have implemented the proposed changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
648418076 https://github.com/pydata/xarray/pull/4020#issuecomment-648418076 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY0ODQxODA3Ng== raphaeldussin 14662821 2020-06-23T21:00:47Z 2020-06-23T21:00:47Z CONTRIBUTOR

all tests passed!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
643450525 https://github.com/pydata/xarray/pull/4020#issuecomment-643450525 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDY0MzQ1MDUyNQ== raphaeldussin 14662821 2020-06-12T19:36:36Z 2020-06-12T19:36:36Z CONTRIBUTOR

@mathause is there anything I can do to make this PR move forward? I fixed the conflict that happened since my last commit. failed tests here seem independent from PR.

thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
629724808 https://github.com/pydata/xarray/pull/4020#issuecomment-629724808 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDYyOTcyNDgwOA== raphaeldussin 14662821 2020-05-17T00:33:52Z 2020-05-17T00:33:52Z CONTRIBUTOR

an example of using cartopy and a custom background:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
629719002 https://github.com/pydata/xarray/pull/4020#issuecomment-629719002 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDYyOTcxOTAwMg== raphaeldussin 14662821 2020-05-16T23:26:42Z 2020-05-17T00:08:25Z CONTRIBUTOR

apologies for the many commits, testing the test was a bit difficult.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092
623076195 https://github.com/pydata/xarray/pull/4020#issuecomment-623076195 https://api.github.com/repos/pydata/xarray/issues/4020 MDEyOklzc3VlQ29tbWVudDYyMzA3NjE5NQ== mathause 10194086 2020-05-03T08:45:58Z 2020-05-03T08:45:58Z MEMBER

facecolor is a valid argument for several of the plotting functions (e.g. pcolormesh). The better approach here would be to thread subplot_kws

https://github.com/pydata/xarray/blob/3820fb77256682d909c1e41d962e29bec0edd62d/xarray/plot/plot.py#L125

through to get_axis

https://github.com/pydata/xarray/blob/3820fb77256682d909c1e41d962e29bec0edd62d/xarray/plot/utils.py#L384

in all the right places (+ tests). This would also solve #3169.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow passing axis kwargs to plot 611238092

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);