issue_comments

Table actions

4 rows where issue = 610687463 and user = 1700203 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • blsqr · 4 ✖

issue 1

  • Add NetCDF3 dtype coercion for unsigned integer types · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
631608640 https://github.com/pydata/xarray/pull/4018#issuecomment-631608640 https://api.github.com/repos/pydata/xarray/issues/4018 MDEyOklzc3VlQ29tbWVudDYzMTYwODY0MA== blsqr 1700203 2020-05-20T17:13:21Z 2020-05-20T17:13:21Z CONTRIBUTOR

Thanks, @dcherian! I'm happy to contribute 😊 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add NetCDF3 dtype coercion for unsigned integer types 610687463
622965234 https://github.com/pydata/xarray/pull/4018#issuecomment-622965234 https://api.github.com/repos/pydata/xarray/issues/4018 MDEyOklzc3VlQ29tbWVudDYyMjk2NTIzNA== blsqr 1700203 2020-05-02T14:47:54Z 2020-05-02T14:47:54Z CONTRIBUTOR

Alright, I added the test. From my side, this would be ready. :)

Let me know if further changes to the tests or What's New are necessary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add NetCDF3 dtype coercion for unsigned integer types 610687463
622389439 https://github.com/pydata/xarray/pull/4018#issuecomment-622389439 https://api.github.com/repos/pydata/xarray/issues/4018 MDEyOklzc3VlQ29tbWVudDYyMjM4OTQzOQ== blsqr 1700203 2020-05-01T13:32:02Z 2020-05-01T13:32:02Z CONTRIBUTOR

@dcherian I think this would be ready for review now. I'd appreciate some guidance on the implementation of the tests; see above.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add NetCDF3 dtype coercion for unsigned integer types 610687463
622342323 https://github.com/pydata/xarray/pull/4018#issuecomment-622342323 https://api.github.com/repos/pydata/xarray/issues/4018 MDEyOklzc3VlQ29tbWVudDYyMjM0MjMyMw== blsqr 1700203 2020-05-01T10:51:20Z 2020-05-01T10:51:20Z CONTRIBUTOR

Currently, the error that is raised by coerce_nc3_dtype is not covered by tests.

A test could look something like this:

```python def test_dtype_coercion_error(self): for dtype in _nc3_dtype_coercions: if dtype == "bool": continue

        # Create some data that cannot be coerced (cause it's a downcast)
        dtype = np.dtype(dtype)
        maxval = np.iinfo(dtype).max
        x = np.array([0, 1, 2, maxval], dtype=dtype)
        test_data = Dataset({"x": ("t", x, {})})

        # Make sure a roundtrip fails
        with pytest.raises(ValueError, match="could not safely cast"):
            self.roundtrip(test_data)

```

... but I'm not sure ... * whether this would be desirable to test * whether this PR should take care of this or not * where in test_backend.py I would have to put the test case such that it's invoked only for netcdf3. * I already found the NetCDF3Only class and requires_scipy decorator, but don't know which test class is responsible here ...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add NetCDF3 dtype coercion for unsigned integer types 610687463

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);