issue_comments

I think this is ready for merging; the fix of the DataArray.plot summary is going to be a new PR. So unless there are any objections I'm going to merge tomorrow.

I added the accessor templates from pandas (we should eventually outsource these to a separate package used by both pandas and xarray) and modified the API page to display the accessor version of the plotting functions.

I think we should add a accessor section to each of the main objects (Dataset and DataArray), where we either copy what pandas does – listing every method / attribute of the accessor as a subsection of the class documentation – or we could show them as attributes (just like what we do for the injected numpy functions) and generate separate pages for the accessors.

where should the docstring of the accessor come from? Right now, this is the docstring of the return value which seems reasonable to me.

I added tests verifying that cls.property returns the accessor class and obj.property the accessor instance. Do we need additional checks for __doc__?.

there are a few of my questions / comments we can resolve by using something like

```python class UncachedAccessor: def init(self, accessor): self._accessor = accessor

def __get__(self, obj, cls):
    if obj is None:
        return self._accessor

    return self._accessor(obj)

```

The only disadvantage is that now pydoc (or help()) show the accessor as a class. That was already the case for str and dt, but plot was a function.

I think we could try to trick inspect.getmembers (which is used to decide which kind of output should be done), but that would require a lot of monkeypatching I'd rather not do.

pandas simply uses the same docstring for the class and __call__, which is not ideal but a lot simpler.

👍 for a simple solution here like pandas rather than using inspect. I think it's probably actually slightly more accurate to show the class.

This is a really clever yet simple fix. I like it!

A few ideas for testing:

• Verify that DataArray.plot returns the PlotMethods object.
• Verify that data_array.plot.__doc__ is still there.

I think pandas might do something similar to do this? It might be worth checking, though it looks like you've figured most of it out already :)

there are a few of my questions / comments we can resolve by using something like ```python class UncachedAccessor: def init(self, accessor): self._accessor = accessor

def __get__(self, obj, cls):
    if obj is None:
        return self._accessor

    return self._accessor(obj)

```

The only disadvantage is that now pydoc (or help()) show the accessor as a class. That was already the case for str and dt, but plot was a function.

I think we could try to trick inspect.getmembers (which is used to decide which kind of output should be done), but that would require a lot of monkeypatching I'd rather not do.

pandas simply uses the same docstring for the class and __call__, which is not ideal but a lot simpler.