issue_comments

Table actions

3 rows where issue = 594594646 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • keewis · 3 ✖

issue 1

  • Support multiple dimensions in DataArray.argmin() and DataArray.argmax() methods · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
650297994 https://github.com/pydata/xarray/pull/3936#issuecomment-650297994 https://api.github.com/repos/pydata/xarray/issues/3936 MDEyOklzc3VlQ29tbWVudDY1MDI5Nzk5NA== keewis 14808389 2020-06-26T17:19:34Z 2020-06-26T17:19:34Z MEMBER

well, we'd need to somehow be able to use sel to index every variable in a Dataset differently. While that would probably be possible it would make sel way too complicated, so I agree that an error would be good here.

I think no further changes to the pint tests should be required (except refactoring, but I can do that in a new PR after this one has been merged).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support multiple dimensions in DataArray.argmin() and DataArray.argmax() methods 594594646
650221609 https://github.com/pydata/xarray/pull/3936#issuecomment-650221609 https://api.github.com/repos/pydata/xarray/issues/3936 MDEyOklzc3VlQ29tbWVudDY1MDIyMTYwOQ== keewis 14808389 2020-06-26T14:51:51Z 2020-06-26T14:51:51Z MEMBER

I noticed a few issues while debugging: - calling on a array with missing values raises ValueError: All-NaN slice encountered (try ds = xr.tutorial.open_dataset("rasm"); ds.argmin(dim="y")) - ds.argmin(dim=...) returns a single index (the same result as ds.argmin()) but ds.Tair.argmin(dim=...) returns something different from ds.Tair.argmin(). Is that intentional?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support multiple dimensions in DataArray.argmin() and DataArray.argmax() methods 594594646
617381475 https://github.com/pydata/xarray/pull/3936#issuecomment-617381475 https://api.github.com/repos/pydata/xarray/issues/3936 MDEyOklzc3VlQ29tbWVudDYxNzM4MTQ3NQ== keewis 14808389 2020-04-21T19:57:27Z 2020-04-21T20:48:41Z MEMBER

you could mark the function("argmin") / function("argmax") with xfail (or skip?). We can decide on what to do with them when we close #3917

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support multiple dimensions in DataArray.argmin() and DataArray.argmax() methods 594594646

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);