issue_comments

Table actions

4 rows where issue = 589471115 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix for stack+groupby+apply w/ non-increasing coord · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
606724922 https://github.com/pydata/xarray/pull/3906#issuecomment-606724922 https://api.github.com/repos/pydata/xarray/issues/3906 MDEyOklzc3VlQ29tbWVudDYwNjcyNDkyMg== max-sixty 5635139 2020-03-31T16:10:16Z 2020-03-31T16:10:16Z MEMBER

Great, thanks again @spencerahill !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for stack+groupby+apply w/ non-increasing coord 589471115
606606170 https://github.com/pydata/xarray/pull/3906#issuecomment-606606170 https://api.github.com/repos/pydata/xarray/issues/3906 MDEyOklzc3VlQ29tbWVudDYwNjYwNjE3MA== spencerahill 6200806 2020-03-31T12:50:02Z 2020-03-31T12:50:02Z CONTRIBUTOR

Great, thanks @max-sixty and happy to do it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for stack+groupby+apply w/ non-increasing coord 589471115
606338020 https://github.com/pydata/xarray/pull/3906#issuecomment-606338020 https://api.github.com/repos/pydata/xarray/issues/3906 MDEyOklzc3VlQ29tbWVudDYwNjMzODAyMA== max-sixty 5635139 2020-03-31T01:13:38Z 2020-03-31T01:13:38Z MEMBER

This looks great @spencerahill ! Tests are very clear. The code fix looks good; I'll leave this open for a day in case those who know the code section better have any comments.

Thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for stack+groupby+apply w/ non-increasing coord 589471115
606291544 https://github.com/pydata/xarray/pull/3906#issuecomment-606291544 https://api.github.com/repos/pydata/xarray/issues/3906 MDEyOklzc3VlQ29tbWVudDYwNjI5MTU0NA== spencerahill 6200806 2020-03-30T22:47:38Z 2020-03-30T22:47:38Z CONTRIBUTOR

OK @max-sixty I've gotten logic that works in the sense that it works for this use case and doesn't break any existing tests. But I could use a look over by somebody more familiar with groupby + multi-indexing, as it's totally possible that this quick fix causes other problems.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix for stack+groupby+apply w/ non-increasing coord 589471115

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);