issue_comments

Table actions

4 rows where issue = 588112617 and user = 1386642 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • nbren12 · 4 ✖

issue 1

  • Add public API for Dataset._copy_listed · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1101553689 https://github.com/pydata/xarray/issues/3894#issuecomment-1101553689 https://api.github.com/repos/pydata/xarray/issues/3894 IC_kwDOAMm_X85BqGAZ nbren12 1386642 2022-04-18T16:41:39Z 2022-04-18T16:41:39Z CONTRIBUTOR

I think the issue is still valid, we just couldn't think of what to name the new API.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add public API for Dataset._copy_listed 588112617
675057700 https://github.com/pydata/xarray/issues/3894#issuecomment-675057700 https://api.github.com/repos/pydata/xarray/issues/3894 MDEyOklzc3VlQ29tbWVudDY3NTA1NzcwMA== nbren12 1386642 2020-08-17T19:03:55Z 2020-08-17T19:03:55Z CONTRIBUTOR

NVM, get is already a method. Maybe we could overload it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add public API for Dataset._copy_listed 588112617
675056880 https://github.com/pydata/xarray/issues/3894#issuecomment-675056880 https://api.github.com/repos/pydata/xarray/issues/3894 MDEyOklzc3VlQ29tbWVudDY3NTA1Njg4MA== nbren12 1386642 2020-08-17T19:02:24Z 2020-08-17T19:02:24Z CONTRIBUTOR

Or maybe "get" since it's a synonym of "select" that isn't overloaded with spatial indexing in the code base.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add public API for Dataset._copy_listed 588112617
675055276 https://github.com/pydata/xarray/issues/3894#issuecomment-675055276 https://api.github.com/repos/pydata/xarray/issues/3894 MDEyOklzc3VlQ29tbWVudDY3NTA1NTI3Ng== nbren12 1386642 2020-08-17T18:59:05Z 2020-08-17T18:59:05Z CONTRIBUTOR

Is there a way in mypy we could use something like overload to specify the above contract here, as an alternative to another method?

That is correct. The output type is predictable from the inputs types. With #4144, mypy may have a chance at detecting this kind of error. Still, I don't know how many users use type-checking. I expect most will only discover this problem at runtime.

It would be better to have an explicit method for subsetting Dataset variables.

I agree. sel_vars is more clear IMO since subset could apply to the coordinates too e.g. a spatial subset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add public API for Dataset._copy_listed 588112617

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);