issue_comments

Table actions

7 rows where issue = 585868107 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
603492993 https://github.com/pydata/xarray/pull/3877#issuecomment-603492993 https://api.github.com/repos/pydata/xarray/issues/3877 MDEyOklzc3VlQ29tbWVudDYwMzQ5Mjk5Mw== max-sixty 5635139 2020-03-24T20:40:07Z 2020-03-24T20:40:07Z MEMBER

Merging — any other feedback please post and we can follow-up on.

Thanks a lot @johnomotani , great PR!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` 585868107
603296862 https://github.com/pydata/xarray/pull/3877#issuecomment-603296862 https://api.github.com/repos/pydata/xarray/issues/3877 MDEyOklzc3VlQ29tbWVudDYwMzI5Njg2Mg== max-sixty 5635139 2020-03-24T15:12:36Z 2020-03-24T15:12:46Z MEMBER

Let's merge later today unless there are other comments?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` 585868107
603188399 https://github.com/pydata/xarray/pull/3877#issuecomment-603188399 https://api.github.com/repos/pydata/xarray/issues/3877 MDEyOklzc3VlQ29tbWVudDYwMzE4ODM5OQ== TomNicholas 35968931 2020-03-24T11:36:10Z 2020-03-24T11:36:52Z MEMBER

For specifying which object, one possibility would be to pass an int

I'm not in favour of an integer argument, for the reasons discussed for open_mfdataset here. We maybe just pass the actual dataset/array object though...

This feature would need new tests writing though, so I'd suggest implementing it in a new PR.

Fine to discuss this on a separate PR though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` 585868107
603134393 https://github.com/pydata/xarray/pull/3877#issuecomment-603134393 https://api.github.com/repos/pydata/xarray/issues/3877 MDEyOklzc3VlQ29tbWVudDYwMzEzNDM5Mw== johnomotani 3958036 2020-03-24T09:42:11Z 2020-03-24T09:42:11Z CONTRIBUTOR

For specifying which object, one possibility would be to pass an int to combine_attrs in merge(), concat() or combine_by_coords(), or a tuple of int to combine_nested, giving the index of the object to use attributes from. This feature would need new tests writing though, so I'd suggest implementing it in a new PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` 585868107
602806659 https://github.com/pydata/xarray/pull/3877#issuecomment-602806659 https://api.github.com/repos/pydata/xarray/issues/3877 MDEyOklzc3VlQ29tbWVudDYwMjgwNjY1OQ== johnomotani 3958036 2020-03-23T19:23:47Z 2020-03-23T19:23:47Z CONTRIBUTOR

Should there perhaps be another option to specify which object to get the attrs from? I'm just thinking by analogy to how open_mfdataset now lets you specify which file you want the attrs from.

That would actually be nice to have in concat() for a use-case I have. It's not immediately obvious to me how to implement it though. For merge() or concat() you could give an integer index. I think open_mfdataset used the file-name (?), but there's no equivalent for combine_by_coords or combine_nested is there?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` 585868107
602801169 https://github.com/pydata/xarray/pull/3877#issuecomment-602801169 https://api.github.com/repos/pydata/xarray/issues/3877 MDEyOklzc3VlQ29tbWVudDYwMjgwMTE2OQ== TomNicholas 35968931 2020-03-23T19:12:19Z 2020-03-23T19:12:19Z MEMBER

Oh sweet!

Should there perhaps be another option to specify which object to get the attrs from? I'm just thinking by analogy to how open_mfdataset now lets you specify which file you want the attrs from.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` 585868107
602740540 https://github.com/pydata/xarray/pull/3877#issuecomment-602740540 https://api.github.com/repos/pydata/xarray/issues/3877 MDEyOklzc3VlQ29tbWVudDYwMjc0MDU0MA== max-sixty 5635139 2020-03-23T17:20:58Z 2020-03-23T17:20:58Z MEMBER

Any other thoughts from anyone before we hit the big green button? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` 585868107

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);