home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where issue = 584461380 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 6

  • dcherian 1
  • benbovy 1
  • bennyrowland 1
  • fujiisoup 1
  • ulijh 1
  • mcdevitts 1

author_association 3

  • MEMBER 3
  • NONE 2
  • CONTRIBUTOR 1

issue 1

  • What should pad do about IndexVariables? · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1047947800 https://github.com/pydata/xarray/issues/3868#issuecomment-1047947800 https://api.github.com/repos/pydata/xarray/issues/3868 IC_kwDOAMm_X84-dmoY benbovy 4160723 2022-02-22T16:02:21Z 2022-02-22T16:02:21Z MEMBER

Would it be conceivable to implement an alternative form of coordinate index which is explicitly a linear coordinate axis, storing only a first point and a step (possibly a last point but that would obviously be redundant with the length of the dimension)

It would be possible to do that after the explicit index refactor is complete (see https://github.com/pydata/xarray/projects/1).

5692 already adds several Xarray methods like isel, sel, concat, stack, roll, rename, etc. to the new Xarray Index base class so that it will be possible to provide alternative indexes as Index sub-classes with custom implementations.

We could certainly add an Index.pad method.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  What should pad do about IndexVariables? 584461380
805783942 https://github.com/pydata/xarray/issues/3868#issuecomment-805783942 https://api.github.com/repos/pydata/xarray/issues/3868 MDEyOklzc3VlQ29tbWVudDgwNTc4Mzk0Mg== bennyrowland 5189118 2021-03-24T12:33:57Z 2021-03-24T12:33:57Z NONE

Would it be conceivable to implement an alternative form of coordinate index which is explicitly a linear coordinate axis, storing only a first point and a step (possibly a last point but that would obviously be redundant with the length of the dimension). This would be trivial to pad via linear extrapolation and the pad function would just have to ask the coordinate to pad itself. This could also in principle extend to other coordinates like a periodic one etc., although I don't personally have a use for those. Coordinates that don't know how to handle being padded can use NaN as currently. I guess that this is one of the things that could be enabled by #1603?

My use case is in MRI reconstruction where we frequently have asymmetric datasets and need to pad them to be symmetric before an IFT. I am using xrft which is great but makes a fuss if the coordinates are not correctly linear and centred on the origin. The degree of asymmetry and the step size change from dataset to dataset, so it is not trivial to assemble the necessary new coordinate values for @fujiisoup's proposed solution.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  What should pad do about IndexVariables? 584461380
784607034 https://github.com/pydata/xarray/issues/3868#issuecomment-784607034 https://api.github.com/repos/pydata/xarray/issues/3868 MDEyOklzc3VlQ29tbWVudDc4NDYwNzAzNA== dcherian 2448579 2021-02-23T23:34:02Z 2021-02-23T23:34:02Z MEMBER

@fujiisoup's suggestions looks good to me. PRs welcome!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  What should pad do about IndexVariables? 584461380
784502064 https://github.com/pydata/xarray/issues/3868#issuecomment-784502064 https://api.github.com/repos/pydata/xarray/issues/3868 MDEyOklzc3VlQ29tbWVudDc4NDUwMjA2NA== mcdevitts 13813076 2021-02-23T20:49:43Z 2021-02-23T20:49:43Z NONE

I'm not sure whether to open a separate feature request or just tag onto this one. Please correct me.

pad is an awesome method. I've used it to easily support interpolating or extrapolating dataarrays that happen to have unitary dimensions, or to quickly support a constant value extrapolation in any dimension. However, to do this, I have to go in and change alter the coords myself since the same value is just repeated.

Would it be possible to add an option that effectively adds "epsilon" to the newly added kwarg?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  What should pad do about IndexVariables? 584461380
625109242 https://github.com/pydata/xarray/issues/3868#issuecomment-625109242 https://api.github.com/repos/pydata/xarray/issues/3868 MDEyOklzc3VlQ29tbWVudDYyNTEwOTI0Mg== ulijh 13190237 2020-05-07T08:27:26Z 2020-05-07T08:27:26Z CONTRIBUTOR

Thanks for implementing this! This is a feature, that we will be using for sure! Mostly with indices of type 1 which, in many cases, can easily be extrapolated. Having this as a default or a switch to enable extrapolation where possible would help a lot!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  What should pad do about IndexVariables? 584461380
601411557 https://github.com/pydata/xarray/issues/3868#issuecomment-601411557 https://api.github.com/repos/pydata/xarray/issues/3868 MDEyOklzc3VlQ29tbWVudDYwMTQxMTU1Nw== fujiisoup 6815844 2020-03-19T20:53:30Z 2020-03-19T20:53:30Z MEMBER

How about passing an Index instead of just a simple integer to the pad method? ```python In [4]: da = xr.DataArray([0.5, 1.5, 2.5], dims=['x'], coords={'x': [0, 1, 2]})

In [5]: da
Out[5]: <xarray.DataArray (x: 3)> array([0.5, 1.5, 2.5]) Coordinates: * x (x) int64 0 1 2

In [8]: da.pad(x=([-1, -2], 0))
Out[8]: <xarray.DataArray (x: 5)> array([nan, nan, 0.5, 1.5, 2.5]) Coordinates: * x (x) int64 -1 -2 0 1 2 ```

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  What should pad do about IndexVariables? 584461380

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 15.598ms · About: xarray-datasette