issue_comments

Table actions

5 rows where issue = 577105538 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Implement skipna kwarg in xr.quantile · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
596317988 https://github.com/pydata/xarray/pull/3844#issuecomment-596317988 https://api.github.com/repos/pydata/xarray/issues/3844 MDEyOklzc3VlQ29tbWVudDU5NjMxNzk4OA== dcherian 2448579 2020-03-09T03:45:16Z 2020-03-09T03:45:16Z MEMBER

Yay thanks @aaronspring.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement skipna kwarg in xr.quantile 577105538
596231359 https://github.com/pydata/xarray/pull/3844#issuecomment-596231359 https://api.github.com/repos/pydata/xarray/issues/3844 MDEyOklzc3VlQ29tbWVudDU5NjIzMTM1OQ== max-sixty 5635139 2020-03-08T17:43:08Z 2020-03-08T17:43:08Z MEMBER

Thanks again @aaronspring !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement skipna kwarg in xr.quantile 577105538
596125505 https://github.com/pydata/xarray/pull/3844#issuecomment-596125505 https://api.github.com/repos/pydata/xarray/issues/3844 MDEyOklzc3VlQ29tbWVudDU5NjEyNTUwNQ== max-sixty 5635139 2020-03-07T18:40:31Z 2020-03-07T18:40:31Z MEMBER

This looks great @aaronspring ! Thanks!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement skipna kwarg in xr.quantile 577105538
595902898 https://github.com/pydata/xarray/pull/3844#issuecomment-595902898 https://api.github.com/repos/pydata/xarray/issues/3844 MDEyOklzc3VlQ29tbWVudDU5NTkwMjg5OA== pep8speaks 24736507 2020-03-06T18:37:07Z 2020-03-07T10:26:25Z NONE

Hello @aaronspring! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-03-07 10:26:25 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement skipna kwarg in xr.quantile 577105538
596072003 https://github.com/pydata/xarray/pull/3844#issuecomment-596072003 https://api.github.com/repos/pydata/xarray/issues/3844 MDEyOklzc3VlQ29tbWVudDU5NjA3MjAwMw== aaronspring 12237157 2020-03-07T10:25:18Z 2020-03-07T10:25:18Z CONTRIBUTOR

I am unsure whether I added enough tests. only one test that checks for different values with or without skipna.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement skipna kwarg in xr.quantile 577105538

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);