issue_comments

Table actions

4 rows where issue = 574097799 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 4 ✖

issue 1

  • Documentation of DataArray does not warn that inferring dimension names is deprecated · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
593969628 https://github.com/pydata/xarray/issues/3820#issuecomment-593969628 https://api.github.com/repos/pydata/xarray/issues/3820 MDEyOklzc3VlQ29tbWVudDU5Mzk2OTYyOA== max-sixty 5635139 2020-03-03T14:10:35Z 2020-03-03T14:10:35Z MEMBER

I definitely agree it's better if possible. I think the tradeoff is between better for almost everyone vs the potential of a break for a small minority.

Currently we support python versions for 42 months, and Python 3.6 was released December 2016. So that means we support it until July 2020 -- given that timeframe I think we wait until then and add this back?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation of DataArray does not warn that inferring dimension names is deprecated 574097799
593700805 https://github.com/pydata/xarray/issues/3820#issuecomment-593700805 https://api.github.com/repos/pydata/xarray/issues/3820 MDEyOklzc3VlQ29tbWVudDU5MzcwMDgwNQ== max-sixty 5635139 2020-03-03T00:20:11Z 2020-03-03T00:20:11Z MEMBER

I guess it's still too soon to 'un-deprecate' this behavior again?

Ha! We do support 3.6. I think that almost everyone is using xarray with CPython, so it's almost certainly safe. But maybe not worth the tradeoff given the benefit is marginal, what are your thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation of DataArray does not warn that inferring dimension names is deprecated 574097799
593574548 https://github.com/pydata/xarray/issues/3820#issuecomment-593574548 https://api.github.com/repos/pydata/xarray/issues/3820 MDEyOklzc3VlQ29tbWVudDU5MzU3NDU0OA== max-sixty 5635139 2020-03-02T19:26:46Z 2020-03-02T19:26:46Z MEMBER

For the PR: in general we don't need to document deprecated behavior, so you can remove than description rather than caveat it

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation of DataArray does not warn that inferring dimension names is deprecated 574097799
593574188 https://github.com/pydata/xarray/issues/3820#issuecomment-593574188 https://api.github.com/repos/pydata/xarray/issues/3820 MDEyOklzc3VlQ29tbWVudDU5MzU3NDE4OA== max-sixty 5635139 2020-03-02T19:26:02Z 2020-03-02T19:26:02Z MEMBER

Agree! Thanks for spotting @sjvrijn . PR is appreciated, thanks for the offer!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Documentation of DataArray does not warn that inferring dimension names is deprecated 574097799

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);