issue_comments

Table actions

3 rows where issue = 568968607 and user = 327925 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • takluyver · 3 ✖

issue 1

  • DataArray.unstack() leaving dimensions 'in order' · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
590001709 https://github.com/pydata/xarray/issues/3786#issuecomment-590001709 https://api.github.com/repos/pydata/xarray/issues/3786 MDEyOklzc3VlQ29tbWVudDU5MDAwMTcwOQ== takluyver 327925 2020-02-22T21:50:46Z 2020-02-22T21:50:46Z MEMBER

If it's easier, a method for "transpose these dimensions to the order which makes the data contiguous" would meet my needs.

I'm happy in principle to work on either feature, but when I've looked into contributing to xarray before, I've been a bit overwhelmed by complexity - I think I'm currently using a pretty small fragment of what it can do.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.unstack() leaving dimensions 'in order' 568968607
589956473 https://github.com/pydata/xarray/issues/3786#issuecomment-589956473 https://api.github.com/repos/pydata/xarray/issues/3786 MDEyOklzc3VlQ29tbWVudDU4OTk1NjQ3Mw== takluyver 327925 2020-02-22T13:30:40Z 2020-02-22T13:30:40Z MEMBER

@max-sixty - I certainly want to avoid copying the data unless it's necessary. But I'd like to present the axes in the 'real' memory order, from the largest stride to the smallest.

I appreciate that it shouldn't matter for program logic, but it can definitely matter for performance, and I know some users are going to use axes by position rather than by name, so I do consider it an important part of the API.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.unstack() leaving dimensions 'in order' 568968607
589707231 https://github.com/pydata/xarray/issues/3786#issuecomment-589707231 https://api.github.com/repos/pydata/xarray/issues/3786 MDEyOklzc3VlQ29tbWVudDU4OTcwNzIzMQ== takluyver 327925 2020-02-21T15:40:04Z 2020-02-21T15:40:04Z MEMBER

Thanks, it makes sense that dimension order conceptually doesn't matter so much once they're labelled. Though I'd say that as Xarray has public APIs for accessing dimensions by position, changing how something like .unstack() orders them probably is a breaking change.

I'm providing an API for other people to access data as a DataArray, and I'd like to have the dimensions in the order that makes it C contiguous, as a hint about what kinds of operations will be efficient. I know some users also go 'what is this complicated thing?' and extract the numpy array from it, in which case the order is more important.

So another option that would work for me would be a separate method that rearranges the dimensions to the order that makes the array C contiguous.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.unstack() leaving dimensions 'in order' 568968607

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);