issue_comments

Table actions

7 rows where issue = 567058587 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Two strange errors in tests TestVariable using .copy() · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
588317037 https://github.com/pydata/xarray/issues/3778#issuecomment-588317037 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4ODMxNzAzNw== keewis 14808389 2020-02-19T16:40:51Z 2020-02-19T16:40:51Z MEMBER

equals returning False in the absence of dask is because of https://github.com/pydata/xarray/blob/52ee5dfe73b51b55cc90f2140f2cd54a2e7946a0/xarray/core/duck_array_ops.py#L74-L81 which uses np.isnat if dask is absent and pd.isnull if dask is present. Since dask_array_type is a tuple, hasattrwill always return False.

Wrapping a datetime in a quantity does not really make sense so I'll try to remove those tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
588279671 https://github.com/pydata/xarray/issues/3778#issuecomment-588279671 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4ODI3OTY3MQ== keewis 14808389 2020-02-19T15:04:50Z 2020-02-19T15:04:50Z MEMBER

since pint became (or will become, once #3594 is closed) a optional dependency, we will definitely have to add it to show_versions.

Note that none of them will fail with dask installed (which is why we didn't catch this with CI): without dask: python d = np.datetime64("NaT", "ns") v = xr.Variable(["x"], ureg.Quantity([d], ureg.m)) assert v.equals(v.copy()) # AssertionError with dask, equals returns True and the tests pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
588189303 https://github.com/pydata/xarray/issues/3778#issuecomment-588189303 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4ODE4OTMwMw== max-sixty 5635139 2020-02-19T12:02:11Z 2020-02-19T12:02:23Z MEMBER

Should pint be added to xr.show_versions?

👍 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
588176698 https://github.com/pydata/xarray/issues/3778#issuecomment-588176698 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4ODE3NjY5OA== ArchangeGabriel 490531 2020-02-19T11:33:35Z 2020-02-19T11:33:35Z CONTRIBUTOR

I have pint 0.10.1, and 0.10 definitively changed a lot of things as also shown in https://github.com/pydata/xarray/issues/3266#issuecomment-587574737.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
588069025 https://github.com/pydata/xarray/issues/3778#issuecomment-588069025 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4ODA2OTAyNQ== mathause 10194086 2020-02-19T07:10:00Z 2020-02-19T07:10:00Z MEMBER

@keewis could it be that the wrong version of pint is installed? Should pint be added to xr.show_versions?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
587943881 https://github.com/pydata/xarray/issues/3778#issuecomment-587943881 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4Nzk0Mzg4MQ== ArchangeGabriel 490531 2020-02-18T22:50:02Z 2020-02-18T22:50:02Z CONTRIBUTOR

Sure: ``` INSTALLED VERSIONS

commit: None python: 3.8.1 (default, Jan 22 2020, 06:38:00) [GCC 9.2.0] python-bits: 64 OS: Linux OS-release: 5.5.3-arch1-1 machine: x86_64 processor: byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: en_US.UTF-8 libhdf5: 1.10.5 libnetcdf: 4.7.3

xarray: 0.15.0 pandas: 1.0.1 numpy: 1.18.1 scipy: 1.4.1 netCDF4: 1.5.3 pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: 1.1.0 nc_time_axis: None PseudoNetCDF: None rasterio: None cfgrib: None iris: None bottleneck: 1.3.1 dask: None distributed: None matplotlib: 3.1.3 cartopy: None seaborn: 0.10.0 numbagg: None setuptools: 45.2.0 pip: None conda: None pytest: 5.3.5 IPython: None sphinx: None ```

BTW, why does it report h5py? I did not see it in the list of optional dependencies. Same for distributed by the way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
587932705 https://github.com/pydata/xarray/issues/3778#issuecomment-587932705 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4NzkzMjcwNQ== mathause 10194086 2020-02-18T22:19:52Z 2020-02-18T22:19:52Z MEMBER

Could you list the versions of the installed packages, i.e. the output of xr. show_versions() 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);