issue_comments

Table actions

5 rows where issue = 567035590 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • test_open_mfdataset_list_attr is ran even when dask is not available · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
588262722 https://github.com/pydata/xarray/issues/3777#issuecomment-588262722 https://api.github.com/repos/pydata/xarray/issues/3777 MDEyOklzc3VlQ29tbWVudDU4ODI2MjcyMg== ArchangeGabriel 490531 2020-02-19T14:31:59Z 2020-02-19T14:31:59Z CONTRIBUTOR

Well, you can’t test every combination of dependencies, especially with the large number of optional ones you have. ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_open_mfdataset_list_attr is ran even when dask is not available 567035590
588249900 https://github.com/pydata/xarray/issues/3777#issuecomment-588249900 https://api.github.com/repos/pydata/xarray/issues/3777 MDEyOklzc3VlQ29tbWVudDU4ODI0OTkwMA== mathause 10194086 2020-02-19T14:08:45Z 2020-02-19T14:08:45Z MEMBER

You mean in your test matrix?

Yes, I was wondering why this was not caught anywhere & I think #3780 is fine.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_open_mfdataset_list_attr is ran even when dask is not available 567035590
588180524 https://github.com/pydata/xarray/issues/3777#issuecomment-588180524 https://api.github.com/repos/pydata/xarray/issues/3777 MDEyOklzc3VlQ29tbWVudDU4ODE4MDUyNA== ArchangeGabriel 490531 2020-02-19T11:42:13Z 2020-02-19T11:42:13Z CONTRIBUTOR

You mean in your test matrix? Then yes. Anyway, I’ve proposed a simple fix in https://github.com/pydata/xarray/pull/3780, not sure if you want to go a different route (like making the test work without dask, not sure if that makes any sense).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_open_mfdataset_list_attr is ran even when dask is not available 567035590
588077635 https://github.com/pydata/xarray/issues/3777#issuecomment-588077635 https://api.github.com/repos/pydata/xarray/issues/3777 MDEyOklzc3VlQ29tbWVudDU4ODA3NzYzNQ== mathause 10194086 2020-02-19T07:37:58Z 2020-02-19T07:37:58Z MEMBER

The test is here:

https://github.com/pydata/xarray/blob/52ee5dfe73b51b55cc90f2140f2cd54a2e7946a0/xarray/tests/test_backends.py#L2543

there is probably no test environment that has netCDF4 but not dask

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_open_mfdataset_list_attr is ran even when dask is not available 567035590
587591747 https://github.com/pydata/xarray/issues/3777#issuecomment-587591747 https://api.github.com/repos/pydata/xarray/issues/3777 MDEyOklzc3VlQ29tbWVudDU4NzU5MTc0Nw== max-sixty 5635139 2020-02-18T17:56:07Z 2020-02-18T17:56:07Z MEMBER

Thanks for finding these @ArchangeGabriel

That one looks like a reasonably easy fix; we just need to surround that test with the standard requires dask decorator...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_open_mfdataset_list_attr is ran even when dask is not available 567035590

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);