issue_comments

Table actions

4 rows where issue = 563202971 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • Fix CFTimeIndex-related errors stemming from updates in pandas · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
598568339 https://github.com/pydata/xarray/pull/3764#issuecomment-598568339 https://api.github.com/repos/pydata/xarray/issues/3764 MDEyOklzc3VlQ29tbWVudDU5ODU2ODMzOQ== shoyer 1217238 2020-03-13T06:14:37Z 2020-03-13T06:14:37Z MEMBER

I'm going to merge this to see if it fixes our doc build...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CFTimeIndex-related errors stemming from updates in pandas 563202971
598567039 https://github.com/pydata/xarray/pull/3764#issuecomment-598567039 https://api.github.com/repos/pydata/xarray/issues/3764 MDEyOklzc3VlQ29tbWVudDU5ODU2NzAzOQ== shoyer 1217238 2020-03-13T06:09:01Z 2020-03-13T06:09:01Z MEMBER

It's also worth noting that this note appears to be causing our doc builds to fail: https://readthedocs.org/projects/xray/builds/10604464/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CFTimeIndex-related errors stemming from updates in pandas 563202971
598566923 https://github.com/pydata/xarray/pull/3764#issuecomment-598566923 https://api.github.com/repos/pydata/xarray/issues/3764 MDEyOklzc3VlQ29tbWVudDU5ODU2NjkyMw== shoyer 1217238 2020-03-13T06:08:34Z 2020-03-13T06:08:34Z MEMBER

These changes look good to me. It's definitely not ideal to be overriding all these details on CFTimeIndex -- this why xarray needs its own indexing API -- but for now it seems like about the best we can do.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CFTimeIndex-related errors stemming from updates in pandas 563202971
592327684 https://github.com/pydata/xarray/pull/3764#issuecomment-592327684 https://api.github.com/repos/pydata/xarray/issues/3764 MDEyOklzc3VlQ29tbWVudDU5MjMyNzY4NA== shoyer 1217238 2020-02-28T05:57:21Z 2020-02-28T05:57:21Z MEMBER

+1 for marking as xfail. There’s no point in keeping the master branch failing if we know what the issue is.

On Thu, Feb 27, 2020 at 7:22 PM Maximilian Roos notifications@github.com wrote:

Re the specific issue, that's a tough one. It could be worth floating on pandas and seeing if they have thoughts...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3764?email_source=notifications&email_token=AAJJFVXTH5QBZHOH47UZIQDRFB7NXA5CNFSM4KTAWZ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENG2V6Y#issuecomment-592292603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVQKSGKMKA35V4JDV4DRFB7NXANCNFSM4KTAWZ7A . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix CFTimeIndex-related errors stemming from updates in pandas 563202971

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);