issue_comments

Table actions

9 rows where issue = 557627188 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Implementation of polyfit and polyval · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
603976716 https://github.com/pydata/xarray/pull/3733#issuecomment-603976716 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDYwMzk3NjcxNg== aulemahal 20629530 2020-03-25T17:26:59Z 2020-03-25T17:26:59Z CONTRIBUTOR

Yay! Many thanks, this will greatly improve our projects.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
603971573 https://github.com/pydata/xarray/pull/3733#issuecomment-603971573 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDYwMzk3MTU3Mw== max-sixty 5635139 2020-03-25T17:17:39Z 2020-03-25T17:17:39Z MEMBER

Great, I'm merging, but post back here for further feedback and we can iterate.

Thank you very much @aulemahal !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
603913308 https://github.com/pydata/xarray/pull/3733#issuecomment-603913308 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDYwMzkxMzMwOA== dcherian 2448579 2020-03-25T15:40:30Z 2020-03-25T15:40:30Z MEMBER

I can take a look later this week if needed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
603901324 https://github.com/pydata/xarray/pull/3733#issuecomment-603901324 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDYwMzkwMTMyNA== aulemahal 20629530 2020-03-25T15:19:53Z 2020-03-25T15:19:53Z CONTRIBUTOR

Ping. It be green.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
603892480 https://github.com/pydata/xarray/pull/3733#issuecomment-603892480 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDYwMzg5MjQ4MA== max-sixty 5635139 2020-03-25T15:04:46Z 2020-03-25T15:04:46Z MEMBER

Thanks @aulemahal . Sorry I missed this: I don't think I get notifications when code is pushed, only on a comment. Ping on green and I'll merge.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
603875018 https://github.com/pydata/xarray/pull/3733#issuecomment-603875018 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDYwMzg3NTAxOA== pep8speaks 24736507 2020-03-25T14:36:08Z 2020-03-25T14:38:12Z NONE

Hello @aulemahal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-03-25 14:38:12 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
598888117 https://github.com/pydata/xarray/pull/3733#issuecomment-598888117 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDU5ODg4ODExNw== max-sixty 5635139 2020-03-13T19:56:28Z 2020-03-13T19:56:28Z MEMBER

This looks really excellent. Thanks @aulemahal !

Any thoughts @dcherian @TomNicholas before we merge?

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
580369935 https://github.com/pydata/xarray/pull/3733#issuecomment-580369935 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDU4MDM2OTkzNQ== aulemahal 20629530 2020-01-30T17:39:54Z 2020-01-30T22:23:31Z CONTRIBUTOR

Oh dask="allowed", that's true! For the coeficients and residuals, I can easily do this stacking and unstacking and return only one variable. So, apply_ufunc could be used. However, it would not be very useful right now, considering they way I implemented the least-squares fit directly. Meaning: the left hand side computation and scaling and the not-fitted-dimensions stacking would be done on each call of numpy.polyfit if I did call it directly. Right now, we save some of this overhead by doing it once before iterating on 1d axes (which is anyway needed with skipna=True).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188
580358271 https://github.com/pydata/xarray/pull/3733#issuecomment-580358271 https://api.github.com/repos/pydata/xarray/issues/3733 MDEyOklzc3VlQ29tbWVudDU4MDM1ODI3MQ== dcherian 2448579 2020-01-30T17:13:29Z 2020-01-30T17:13:29Z MEMBER

Just a quick comment:

xr.apply_ufunc, but that makes chunking along the fitted dimension forbidden

dask="allowed" should work and is appropriate here since you're using a dask function.

difficult to return the ancillary results

yes we really should fix this. One trick is to stack the returned information in to one array and split that array up into multiple dataarrays after the apply_ufunc call.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implementation of polyfit and polyval 557627188

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);