issue_comments

Table actions

9 rows where issue = 554662467 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Add isort to CI · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
579420499 https://github.com/pydata/xarray/pull/3721#issuecomment-579420499 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3OTQyMDQ5OQ== dcherian 2448579 2020-01-28T19:41:47Z 2020-01-28T19:41:47Z MEMBER

OK. thanks @crusaderky 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
579402650 https://github.com/pydata/xarray/pull/3721#issuecomment-579402650 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3OTQwMjY1MA== max-sixty 5635139 2020-01-28T19:00:31Z 2020-01-28T19:00:31Z MEMBER

Thank you @crusaderky 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
579402585 https://github.com/pydata/xarray/pull/3721#issuecomment-579402585 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3OTQwMjU4NQ== max-sixty 5635139 2020-01-28T19:00:22Z 2020-01-28T19:00:22Z MEMBER

Just in case my previous comments were unclear, I think we should merge this! (and then reassess if we get complaints, which I give ~20% likelihood)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
578282643 https://github.com/pydata/xarray/pull/3721#issuecomment-578282643 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3ODI4MjY0Mw== max-sixty 5635139 2020-01-24T20:10:23Z 2020-01-24T20:10:23Z MEMBER

I know, I know :)

Potentially we have different priors on whether people might get stuck on all the setup. I hope there's no one, and if there is we can decide what to do!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
578165339 https://github.com/pydata/xarray/pull/3721#issuecomment-578165339 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3ODE2NTMzOQ== crusaderky 6213168 2020-01-24T14:59:40Z 2020-01-24T14:59:40Z MEMBER

@max-sixty that's what PULL_REQUEST_TEMPLATE.md is for...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
578164337 https://github.com/pydata/xarray/pull/3721#issuecomment-578164337 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3ODE2NDMzNw== max-sixty 5635139 2020-01-24T14:57:25Z 2020-01-24T14:57:25Z MEMBER

Yes; I'm particularly thinking of someone making their first contribution, maybe without all the linters and tools locally, and getting stymied by a slightly incorrect import.

Ofc the tool would have to respect isort:skip...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
578153657 https://github.com/pydata/xarray/pull/3721#issuecomment-578153657 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3ODE1MzY1Nw== crusaderky 6213168 2020-01-24T14:31:24Z 2020-01-24T14:31:24Z MEMBER

@max-sixty I wouldn't 100% advise using such level of automation for isort. Have a look at the # isort:skip tags in our codebase; they're all cases where isort would otherwise break the code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
578150860 https://github.com/pydata/xarray/pull/3721#issuecomment-578150860 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3ODE1MDg2MA== max-sixty 5635139 2020-01-24T14:24:38Z 2020-01-24T14:24:38Z MEMBER

+0.2, and we can revert if people really complain.

If there were a tool to autocorrect PRs (i.e. not just fail CI, but offer to add commits to correct the problems), that would be great

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467
578084177 https://github.com/pydata/xarray/pull/3721#issuecomment-578084177 https://api.github.com/repos/pydata/xarray/issues/3721 MDEyOklzc3VlQ29tbWVudDU3ODA4NDE3Nw== crusaderky 6213168 2020-01-24T10:59:21Z 2020-01-24T10:59:21Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isort to CI 554662467

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);