issue_comments

Table actions

14 rows where issue = 552994673 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • bump min deps for 0.15 · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
578314288 https://github.com/pydata/xarray/pull/3713#issuecomment-578314288 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3ODMxNDI4OA== dcherian 2448579 2020-01-24T21:45:43Z 2020-01-24T21:46:46Z MEMBER

the most recent version released more than X months ago.

To me, this seems most sensible.

EDIT: crusaderky's 1 year proposal sounds good too

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
578312410 https://github.com/pydata/xarray/pull/3713#issuecomment-578312410 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3ODMxMjQxMA== crusaderky 6213168 2020-01-24T21:39:46Z 2020-01-24T21:39:46Z MEMBER

We could increase the support window for seldom-updated packages (read: not dask) to 1 year. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
578295750 https://github.com/pydata/xarray/pull/3713#issuecomment-578295750 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3ODI5NTc1MA== max-sixty 5635139 2020-01-24T20:48:46Z 2020-01-24T20:48:46Z MEMBER

For sure no harm in keeping older ones for this release. But to the extent we can have a policy we agree on, then it's not a judgement call each release. Should we change the policy?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
578288717 https://github.com/pydata/xarray/pull/3713#issuecomment-578288717 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3ODI4ODcxNw== crusaderky 6213168 2020-01-24T20:28:25Z 2020-01-24T20:28:25Z MEMBER

I have no problems with supporting versions older than those mandated by the policy as long as there isn't any major benefit in dropping them... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
576784205 https://github.com/pydata/xarray/pull/3713#issuecomment-576784205 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3Njc4NDIwNQ== pep8speaks 24736507 2020-01-21T17:13:35Z 2020-01-24T17:47:42Z NONE

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-01-24 17:47:42 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
578231137 https://github.com/pydata/xarray/pull/3713#issuecomment-578231137 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3ODIzMTEzNw== dcherian 2448579 2020-01-24T17:47:10Z 2020-01-24T17:47:10Z MEMBER

bumping the following seems a little excessive to me.

bottleneck 1.2 (2017-09-18) 1.3 (2019-11-13) < iris 2.2 (2018-10-12) 2.3 (2019-12-21) < numba 0.44 (2019-06-18) 0.46 (2019-10-25) < pseudonetcdf 3.0 (2019-07-18) 3.1 (2019-10-18) < rasterio 1.0 (2018-12-21) 1.1 (2019-10-15) < zarr 2.3 (2019-03-25) 2.4 (2020-01-11) <

Is anyone opposed to merging this PR in its current form and bumping up minimum versions at the next major release?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
577816539 https://github.com/pydata/xarray/pull/3713#issuecomment-577816539 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3NzgxNjUzOQ== crusaderky 6213168 2020-01-23T18:40:29Z 2020-01-23T18:40:29Z MEMBER

Because NEP29 states support for all versions in the latest X months, not the most recent version released more than X months ago. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
577253423 https://github.com/pydata/xarray/pull/3713#issuecomment-577253423 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3NzI1MzQyMw== dcherian 2448579 2020-01-22T15:55:19Z 2020-01-22T15:55:19Z MEMBER

This output is confusing to me. It hasn't been 6 months since bottleneck 1.3 was released. Why is that the "policy version". Similarly for zarr 2.4

``` Package Required Policy Status

python 3.6 (2016-12-23) 3.6 (2016-12-23) = boto3 1.9 (2018-09-10) 1.10 (2019-10-22) < bottleneck 1.2 (2017-09-18) 1.3 (2019-11-13) < cartopy 0.17 (2018-11-17) 0.17 (2018-11-17) = cdms2 3.1 (2018-11-02) 3.1 (2018-11-02) = cfgrib 0.9 (2019-02-25) 0.9 (2019-02-25) = cftime 1.0 (2018-04-27) 1.0 (2018-04-27) = dask 1.2 (2019-04-13) 2.2 (2019-08-01) < distributed 1.27 (2019-04-12) 2.2 (2019-08-01) < h5netcdf 0.7 (2019-02-27) 0.7 (2019-02-27) = h5py 2.9 (2018-12-20) 2.10 (2019-09-10) < hdf5 1.10 (2017-09-18) 1.10 (2017-09-18) = iris 2.2 (2018-10-12) 2.3 (2019-12-21) < lxml 4.4 (2019-07-27) 4.4 (2019-07-27) = matplotlib 3.1 (2019-05-18) 3.1 (2019-05-18) = nc-time-axis 1.2 (2019-01-25) 1.2 (2019-01-25) = netcdf4 1.4 (2018-05-08) 1.4 (2018-05-08) = numba 0.44 (2019-06-18) 0.46 (2019-10-25) < numpy 1.15 (2018-07-27) 1.15 (2018-07-27) = pandas 0.25 (2019-07-18) 0.25 (2019-07-18) = pseudonetcdf 3.0 (2019-07-18) 3.1 (2019-10-18) < pydap 3.2 (2018-10-16) 3.2 (2018-10-16) = pynio 1.5 (2017-12-01) 1.5 (2017-12-01) = rasterio 1.0 (2018-12-21) 1.1 (2019-10-15) < scipy 1.3 (2019-05-28) 1.3 (2019-05-28) = seaborn 0.9 (2018-07-17) 0.9 (2018-07-17) = toolz 0.10 (2019-07-12) 0.10 (2019-07-12) = zarr 2.3 (2019-03-25) 2.4 (2020-01-11) < ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
577166188 https://github.com/pydata/xarray/pull/3713#issuecomment-577166188 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3NzE2NjE4OA== crusaderky 6213168 2020-01-22T12:51:48Z 2020-01-22T12:51:48Z MEMBER

Related: #3714 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
576785872 https://github.com/pydata/xarray/pull/3713#issuecomment-576785872 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3Njc4NTg3Mg== keewis 14808389 2020-01-21T17:17:22Z 2020-01-21T17:17:22Z MEMBER

I think it's fine if you mark the failing tests as xfail

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
576784963 https://github.com/pydata/xarray/pull/3713#issuecomment-576784963 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3Njc4NDk2Mw== dcherian 2448579 2020-01-21T17:15:22Z 2020-01-21T17:15:22Z MEMBER

as @jthielen said, it does not since I never realized we used nanquantile (did we change that recently?).

I changed it in this PR. But I guess I could just revert that bit

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
576783960 https://github.com/pydata/xarray/pull/3713#issuecomment-576783960 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3Njc4Mzk2MA== keewis 14808389 2020-01-21T17:13:05Z 2020-01-21T17:13:05Z MEMBER

as @jthielen said, it does not since I never realized we used nanquantile (did we change that recently?). For now, I'd mark these tests as xfail(reason="not implemented by pint") since none of the pint-support PRs are merged yet. Can be a new PR, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
576782065 https://github.com/pydata/xarray/pull/3713#issuecomment-576782065 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3Njc4MjA2NQ== jthielen 3460034 2020-01-21T17:08:39Z 2020-01-21T17:08:39Z CONTRIBUTOR

looks like pint doesn't have nanquantile?

@dcherian Hope you don't mind me jumping in, but that is correct at the moment (see https://github.com/hgrecco/pint/issues/981). It would be easy to add to Pint, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673
576779512 https://github.com/pydata/xarray/pull/3713#issuecomment-576779512 https://api.github.com/repos/pydata/xarray/issues/3713 MDEyOklzc3VlQ29tbWVudDU3Njc3OTUxMg== dcherian 2448579 2020-01-21T17:03:15Z 2020-01-21T17:03:15Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bump min deps for 0.15 552994673

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);