issue_comments

Table actions

17 rows where issue = 551484736 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • release 0.15.0? · 17 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
581515477 https://github.com/pydata/xarray/issues/3702#issuecomment-581515477 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MTUxNTQ3Nw== dcherian 2448579 2020-02-03T17:04:40Z 2020-02-03T17:04:40Z MEMBER

Done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580833271 https://github.com/pydata/xarray/issues/3702#issuecomment-580833271 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDgzMzI3MQ== crusaderky 6213168 2020-01-31T17:38:07Z 2020-01-31T17:38:07Z MEMBER

ERROR: Could not find a version that satisfies the requirement setuptools_scm (from versions: none) ERROR: No matching distribution found for setuptools_scm

Should get fixed by changing recipe/meta.yaml: yaml requirements: build: - python >=3.6 - pip - setuptools - setuptools_scm

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580827400 https://github.com/pydata/xarray/issues/3702#issuecomment-580827400 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDgyNzQwMA== dcherian 2448579 2020-01-31T17:21:50Z 2020-01-31T17:21:50Z MEMBER

Update: RTD is fixed but the conda-forge channel needs some attention: https://github.com/conda-forge/xarray-feedstock/pull/54

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580558274 https://github.com/pydata/xarray/issues/3702#issuecomment-580558274 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDU1ODI3NA== max-sixty 5635139 2020-01-31T02:47:53Z 2020-01-31T02:47:53Z MEMBER

Thanks @dcherian !

And @keewis for being so helpful recently!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580402703 https://github.com/pydata/xarray/issues/3702#issuecomment-580402703 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDQwMjcwMw== keewis 14808389 2020-01-30T18:59:05Z 2020-01-30T18:59:05Z MEMBER

that's because conda uses too much memory. We might be able to reduce the memory consumption by moving most packages into the pip section (except from iris and cartopy every package should have wheels PyPI)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580401629 https://github.com/pydata/xarray/issues/3702#issuecomment-580401629 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDQwMTYyOQ== dcherian 2448579 2020-01-30T18:56:42Z 2020-01-30T18:56:42Z MEMBER

great RTD is now failing consistently: https://readthedocs.org/projects/xray/builds/

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 1,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580395470 https://github.com/pydata/xarray/issues/3702#issuecomment-580395470 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDM5NTQ3MA== dcherian 2448579 2020-01-30T18:42:34Z 2020-01-30T18:42:34Z MEMBER

OK everything but the email, twitter announcements is done. I'll get to that tonight/tomorrow

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580391235 https://github.com/pydata/xarray/issues/3702#issuecomment-580391235 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDM5MTIzNQ== keewis 14808389 2020-01-30T18:32:14Z 2020-01-30T18:32:14Z MEMBER

did you tag already? If not, I think it might be good to get #3732 in.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580390213 https://github.com/pydata/xarray/issues/3702#issuecomment-580390213 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDM5MDIxMw== dcherian 2448579 2020-01-30T18:29:40Z 2020-01-30T18:29:40Z MEMBER

will reindent the lines not preceded by the bullet (-) to match the indent of the bullet.

That was it!

Is there a reason why we put a string there instead of using something like file: README.rst?

No idea. let's tackle this after this release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580389544 https://github.com/pydata/xarray/issues/3702#issuecomment-580389544 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDM4OTU0NA== keewis 14808389 2020-01-30T18:27:57Z 2020-01-30T18:27:57Z MEMBER

the reason for this is that we have bullet lists with more than one line per item. python setup.py sdist (and others) will reindent the lines not preceded by the bullet (-) to match the indent of the bullet.

Is there a reason why we put a string there instead of using something like file: README.rst?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580389018 https://github.com/pydata/xarray/issues/3702#issuecomment-580389018 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDM4OTAxOA== rabernat 1197350 2020-01-30T18:26:37Z 2020-01-30T18:26:37Z MEMBER

Thanks @dcherian for handling this release!

I believe this is the problem. (line 39 of the description is like 47 of the file)

https://github.com/pydata/xarray/blob/7c32c8ae77557178d618abe65924baf89667b55c/setup.cfg#L46-L47

I guess we are not continuing the line properly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580380168 https://github.com/pydata/xarray/issues/3702#issuecomment-580380168 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDM4MDE2OA== dcherian 2448579 2020-01-30T18:04:23Z 2020-01-30T18:04:23Z MEMBER

git clean -xdf; python setup.py bdist_wheel sdist; twine check dist/*

gives me `long_description` has syntax errors in markup and would not be rendered on PyPI. line 39: Warning: Bullet list ends without a blank line; unexpected unindent.

Can someone figure what needs to be fixed please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580318515 https://github.com/pydata/xarray/issues/3702#issuecomment-580318515 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDMxODUxNQ== keewis 14808389 2020-01-30T15:53:10Z 2020-01-30T15:53:10Z MEMBER

no objections from me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
580317514 https://github.com/pydata/xarray/issues/3702#issuecomment-580317514 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU4MDMxNzUxNA== dcherian 2448579 2020-01-30T15:51:06Z 2020-01-30T15:51:50Z MEMBER

I am doing this (EDIT): in the next two hours unless there are objections.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
579519530 https://github.com/pydata/xarray/issues/3702#issuecomment-579519530 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU3OTUxOTUzMA== dcherian 2448579 2020-01-28T23:18:08Z 2020-01-28T23:18:08Z MEMBER

Do we have volunteers to do this release?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
578336568 https://github.com/pydata/xarray/issues/3702#issuecomment-578336568 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU3ODMzNjU2OA== dcherian 2448579 2020-01-24T23:04:57Z 2020-01-24T23:04:57Z MEMBER

Should be ready to go once #3631 is in.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736
575684379 https://github.com/pydata/xarray/issues/3702#issuecomment-575684379 https://api.github.com/repos/pydata/xarray/issues/3702 MDEyOklzc3VlQ29tbWVudDU3NTY4NDM3OQ== keewis 14808389 2020-01-17T15:58:42Z 2020-01-17T15:58:42Z MEMBER

I'd say all of the PRs related to #3594 (making all non-indexing tests pass and documentation) should be put into the same release. There is not too much to do so if I get about a week I can make sure all of them are ready for review / merge, but I'm also fine with not including them in 0.15

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   release 0.15.0? 551484736

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);