issue_comments

Table actions

5 rows where issue = 548413554 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Allow binned coordinates on 1D plots y-axis. · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
577386737 https://github.com/pydata/xarray/pull/3685#issuecomment-577386737 https://api.github.com/repos/pydata/xarray/issues/3685 MDEyOklzc3VlQ29tbWVudDU3NzM4NjczNw== dcherian 2448579 2020-01-22T21:09:39Z 2020-01-22T21:09:39Z MEMBER

Great. Thanks @juseg. I've run into this before so it's nice to see it fixed.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow binned coordinates on 1D plots y-axis. 548413554
577121575 https://github.com/pydata/xarray/pull/3685#issuecomment-577121575 https://api.github.com/repos/pydata/xarray/issues/3685 MDEyOklzc3VlQ29tbWVudDU3NzEyMTU3NQ== juseg 1186928 2020-01-22T10:43:41Z 2020-01-22T10:43:41Z CONTRIBUTOR

@dcherian Do you mean merge #3274 here (not sure what's the best workflow)? Also am I correct this will break compatibility with matplotlib<3.1? I think I'm done otherwise.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow binned coordinates on 1D plots y-axis. 548413554
575668526 https://github.com/pydata/xarray/pull/3685#issuecomment-575668526 https://api.github.com/repos/pydata/xarray/issues/3685 MDEyOklzc3VlQ29tbWVudDU3NTY2ODUyNg== dcherian 2448579 2020-01-17T15:19:52Z 2020-01-17T15:19:52Z MEMBER

Not sure there is a good difference. It looks like some refactoring may be a good idea. For now I would just stick the test wherever it is easiest.

Also this may be a good time to incorporate the changes from #3274

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow binned coordinates on 1D plots y-axis. 548413554
575643859 https://github.com/pydata/xarray/pull/3685#issuecomment-575643859 https://api.github.com/repos/pydata/xarray/issues/3685 MDEyOklzc3VlQ29tbWVudDU3NTY0Mzg1OQ== juseg 1186928 2020-01-17T14:18:23Z 2020-01-17T14:18:23Z CONTRIBUTOR

@dcherian could you please briefly explain the difference between class TestPlot and class TestPlot1D or point me to docs on that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow binned coordinates on 1D plots y-axis. 548413554
573305245 https://github.com/pydata/xarray/pull/3685#issuecomment-573305245 https://api.github.com/repos/pydata/xarray/issues/3685 MDEyOklzc3VlQ29tbWVudDU3MzMwNTI0NQ== juseg 1186928 2020-01-11T10:45:49Z 2020-01-11T10:53:59Z CONTRIBUTOR

@dcherian Thanks for pointing the problematic code (in #3571). This commit (b8f082b) solves the issue, I think. Or do you think it will be cleaner with a new util _resolve_intervals_1dplot (similar to the existing _resolve_intervals_2dplot)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow binned coordinates on 1D plots y-axis. 548413554

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);