issue_comments

Table actions

4 rows where issue = 545764524 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Cannot roundtrip time in NETCDF4_CLASSIC · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
575282633 https://github.com/pydata/xarray/issues/3665#issuecomment-575282633 https://api.github.com/repos/pydata/xarray/issues/3665 MDEyOklzc3VlQ29tbWVudDU3NTI4MjYzMw== mathause 10194086 2020-01-16T18:27:14Z 2020-01-16T18:27:14Z MEMBER

3652 helps indeed. Example 1 from above now works without error. Example 2 still throws an error. However, I think this is fine, because you are unlikely to end up with an encoding that defines only a _FillValue and not a dtype.

I close this for now unless you disagree?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot roundtrip time in NETCDF4_CLASSIC 545764524
574730653 https://github.com/pydata/xarray/issues/3665#issuecomment-574730653 https://api.github.com/repos/pydata/xarray/issues/3665 MDEyOklzc3VlQ29tbWVudDU3NDczMDY1Mw== mathause 10194086 2020-01-15T16:09:16Z 2020-01-15T16:09:16Z MEMBER

todo: Check if #3652 helps

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot roundtrip time in NETCDF4_CLASSIC 545764524
571202598 https://github.com/pydata/xarray/issues/3665#issuecomment-571202598 https://api.github.com/repos/pydata/xarray/issues/3665 MDEyOklzc3VlQ29tbWVudDU3MTIwMjU5OA== mathause 10194086 2020-01-06T16:17:47Z 2020-01-06T16:17:47Z MEMBER

This happens in:

https://github.com/pydata/xarray/blob/db36c5c0cdee2f5313a81fdeca8a8ae5491d1c8f/xarray/conventions.py#L106

My current workaround is:

``` python if "time" in ds: ds.time.encoding.pop("_FillValue", None)

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot roundtrip time in NETCDF4_CLASSIC 545764524
571186961 https://github.com/pydata/xarray/issues/3665#issuecomment-571186961 https://api.github.com/repos/pydata/xarray/issues/3665 MDEyOklzc3VlQ29tbWVudDU3MTE4Njk2MQ== dcherian 2448579 2020-01-06T15:38:47Z 2020-01-06T15:38:47Z MEMBER

The problem is that xarray adds a (unnecessary) _FillValue when saving a file.

yes. I think we should fix this. It breaks roundtripping 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot roundtrip time in NETCDF4_CLASSIC 545764524

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);