issue_comments

Table actions

7 rows where issue = 540451721 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • [WIP] GroupBy plotting · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
898702359 https://github.com/pydata/xarray/pull/3646#issuecomment-898702359 https://api.github.com/repos/pydata/xarray/issues/3646 IC_kwDOAMm_X841kRwX github-actions[bot] 41898282 2021-08-13T20:24:18Z 2021-11-01T00:42:50Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   56m 9s :stopwatch: 16 295 tests 14 556 :heavy_check_mark: 1 739 :zzz: 0 :x: 90 966 runs  82 768 :heavy_check_mark: 8 198 :zzz: 0 :x:

Results for commit 8f4ea871.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] GroupBy plotting 540451721
569966964 https://github.com/pydata/xarray/pull/3646#issuecomment-569966964 https://api.github.com/repos/pydata/xarray/issues/3646 MDEyOklzc3VlQ29tbWVudDU2OTk2Njk2NA== pep8speaks 24736507 2019-12-31T17:59:58Z 2021-11-01T00:19:11Z NONE

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-11-01 00:19:11 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] GroupBy plotting 540451721
955803547 https://github.com/pydata/xarray/pull/3646#issuecomment-955803547 https://api.github.com/repos/pydata/xarray/issues/3646 IC_kwDOAMm_X844-Geb Illviljan 14371165 2021-10-31T22:33:37Z 2021-10-31T22:33:37Z MEMBER

A few notes before I forget them: * Docs crashed because UncachedAccessor wasn't used. * _plot2d stuff didn't work because of the missing ndim. * ds.A.groupby(ds.w).plot.contour(col="w", row="z") didn't work even though ds.A.plot.contour(col="w", row="z") did. Made that work. The facegrids aren't an exact copy though, the curves are the same but may be in other subplots, there's some sorting going on somewhere. * I think we should avoid adding DataArrayGroupby to the mix in plot.py, I think it'll look cleaner if we always send in pure dataarrays there and do the filtering in DataArrayGroupby.plot instead. Might avoid circular imports then as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] GroupBy plotting 540451721
898870319 https://github.com/pydata/xarray/pull/3646#issuecomment-898870319 https://api.github.com/repos/pydata/xarray/issues/3646 IC_kwDOAMm_X841k6wv Illviljan 14371165 2021-08-14T09:23:34Z 2021-08-14T09:23:34Z MEMBER

python ds = xr.tutorial.scatter_example_dataset() ds.A.groupby(ds.w).plot.contour() ds.A.groupby(ds.w).plot.imshow() These crashes with AttributeError: 'DataArrayGroupBy' object has no attribute 'ndim'. Can NdimSizeLenMixin be used here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] GroupBy plotting 540451721
898709361 https://github.com/pydata/xarray/pull/3646#issuecomment-898709361 https://api.github.com/repos/pydata/xarray/issues/3646 IC_kwDOAMm_X841kTdx dcherian 2448579 2021-08-13T20:40:33Z 2021-08-13T20:40:33Z MEMBER

@Illviljan would you mind testing this out and possibly reviewing it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] GroupBy plotting 540451721
715995178 https://github.com/pydata/xarray/pull/3646#issuecomment-715995178 https://api.github.com/repos/pydata/xarray/issues/3646 MDEyOklzc3VlQ29tbWVudDcxNTk5NTE3OA== dcherian 2448579 2020-10-24T16:58:52Z 2020-10-24T16:58:52Z MEMBER

It should be possible but is not implemented yet.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] GroupBy plotting 540451721
715946540 https://github.com/pydata/xarray/pull/3646#issuecomment-715946540 https://api.github.com/repos/pydata/xarray/issues/3646 MDEyOklzc3VlQ29tbWVudDcxNTk0NjU0MA== Illviljan 14371165 2020-10-24T15:44:38Z 2020-10-24T15:44:38Z MEMBER

This is looking great! Being able to easily plot your groupings like this is so useful. Especially when grouping results isn't trivial and requires a bit of tuning.

When I've been doing these kinds of plots I've mostly just changed the colors for each group: Would it be easy to do this with this implementation?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [WIP] GroupBy plotting 540451721

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);