issue_comments

Table actions

11 rows where issue = 538620718 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add support for CFTimeIndex in get_clean_interp_index · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
578529854 https://github.com/pydata/xarray/pull/3631#issuecomment-578529854 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODUyOTg1NA== huard 81219 2020-01-26T18:36:23Z 2020-01-26T18:36:23Z CONTRIBUTOR

Thanks @spencerkclark for shepherding this to completion. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578505415 https://github.com/pydata/xarray/pull/3631#issuecomment-578505415 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODUwNTQxNQ== spencerkclark 6628425 2020-01-26T14:10:54Z 2020-01-26T14:10:54Z MEMBER

Thanks @huard!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
571242751 https://github.com/pydata/xarray/pull/3631#issuecomment-571242751 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3MTI0Mjc1MQ== pep8speaks 24736507 2020-01-06T18:00:33Z 2020-01-26T13:27:14Z NONE

Hello @huard! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-01-26 13:27:14 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578322789 https://github.com/pydata/xarray/pull/3631#issuecomment-578322789 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODMyMjc4OQ== spencerkclark 6628425 2020-01-24T22:13:11Z 2020-01-24T22:13:11Z MEMBER

Indeed thanks @huard -- I'll give this another once-over tomorrow. If everything checks out, which I anticipate it will, I'll merge it then.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578315239 https://github.com/pydata/xarray/pull/3631#issuecomment-578315239 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODMxNTIzOQ== dcherian 2448579 2020-01-24T21:49:00Z 2020-01-24T21:49:00Z MEMBER

Thanks @huard and @spencerkclark. This took a solid amount of work.

@spencerkclark merge if you think it's good to go?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578288582 https://github.com/pydata/xarray/pull/3631#issuecomment-578288582 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODI4ODU4Mg== huard 81219 2020-01-24T20:27:59Z 2020-01-24T20:27:59Z CONTRIBUTOR

Ah ! No, I tried numpy.testing's version. Works now. Thanks !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578272334 https://github.com/pydata/xarray/pull/3631#issuecomment-578272334 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODI3MjMzNA== spencerkclark 6628425 2020-01-24T19:41:15Z 2020-01-24T19:41:15Z MEMBER

It seems like assert_allclose doesn't like nans. Other suggestion ?

Hmm...I think it should treat NaNs as equal by default. Are you using the version defined here?

https://github.com/pydata/xarray/blob/ecd67f457240db5bc3316c092ca0bb3a134b4239/xarray/tests/init.py#L170

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578264526 https://github.com/pydata/xarray/pull/3631#issuecomment-578264526 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODI2NDUyNg== huard 81219 2020-01-24T19:20:11Z 2020-01-24T19:20:11Z CONTRIBUTOR

It seems like assert_allclose doesn't like nans. Other suggestion ? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578245227 https://github.com/pydata/xarray/pull/3631#issuecomment-578245227 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODI0NTIyNw== dcherian 2448579 2020-01-24T18:26:09Z 2020-01-24T18:26:09Z MEMBER

I think it's just this function: def test_interpolate_na_max_gap_time_specifier. If you switch assert_equal to assert_allclose things should work

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578244381 https://github.com/pydata/xarray/pull/3631#issuecomment-578244381 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODI0NDM4MQ== huard 81219 2020-01-24T18:23:46Z 2020-01-24T18:23:46Z CONTRIBUTOR

I think so. If there's a branch fixing the assert_allclose failures, I can merge it here. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718
578231521 https://github.com/pydata/xarray/pull/3631#issuecomment-578231521 https://api.github.com/repos/pydata/xarray/issues/3631 MDEyOklzc3VlQ29tbWVudDU3ODIzMTUyMQ== dcherian 2448579 2020-01-24T17:48:16Z 2020-01-24T17:48:16Z MEMBER

Is the switch to assert_allclose all that is left here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support for CFTimeIndex in get_clean_interp_index 538620718

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);